Skip to content

vCPU hotunplug related memory leaks

Mark Kanda qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 10 repliesIn review
  2. v25 patches 5 repliesSuperseded
  3. v14 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- patch 4: create cpu_address_space_destroy() to free cpu_ases (Phillipe)
- patch 5: create <kvm, hvf>_destroy_vcpu_thread() to free xsave_buf (Phillipe)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5accel: Introduce AccelOpsClass::destroy_vcpu_thread()include/sysemu/accel-ops.h softmmu/cpus.c+4 -00 replies
2/5softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread()accel/accel-common.c accel/hvf/hvf-accel-ops.c accel/kvm/kvm-accel-ops.c +7 more+16 -02 replies
3/5softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()accel/accel-common.c+1 -03 replies
4/5cpu: Free cpu->cpu_ases in cpu_address_space_destroy()cpu.c include/exec/cpu-common.h softmmu/physmem.c+13 -02 replies
5/5i386/cpu: Free env->xsave_buf in KVM and HVF destory_vcpu_thread routinesaccel/hvf/hvf-accel-ops.c accel/kvm/kvm-accel-ops.c+20 -23 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/5R-b
2/5R-b
3/5
4/5T-b R-b
5/5T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] vCPU hotunplug related memory leaks

This series addresses a few vCPU hotunplug related leaks (found with Valgrind).

v3:
- patch 4: create cpu_address_space_destroy() to free cpu_ases (Phillipe)
- patch 5: create <kvm, hvf>_destroy_vcpu_thread() to free xsave_buf (Phillipe)

v2: Create AccelOpsClass::destroy_vcpu_thread() for vcpu thread related cleanup (Philippe)

Mark Kanda (5):
accel: Introduce AccelOpsClass::destroy_vcpu_thread() softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread() softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()
cpu: Free cpu->cpu_ases in cpu_address_space_destroy() i386/cpu: Free env->xsave_buf in KVM and HVF destory_vcpu_thread
routines

 accel/accel-common.c              |  7 +++++++
 accel/hvf/hvf-accel-ops.c         | 10 ++++++++++
 accel/kvm/kvm-accel-ops.c         | 10 ++++++++++
 accel/qtest/qtest.c               |  1 +
 accel/tcg/tcg-accel-ops.c         |  1 +
 accel/xen/xen-all.c               |  1 +
 cpu.c                             |  1 +
 include/exec/cpu-common.h         |  7 +++++++
 include/sysemu/accel-ops.h        |  3 +++
 softmmu/cpus.c                    |  3 +++
 softmmu/physmem.c                 |  5 +++++
 target/i386/hax/hax-accel-ops.c   |  1 +
 target/i386/nvmm/nvmm-accel-ops.c |  1 +
 target/i386/whpx/whpx-accel-ops.c |  1 +
 14 files changed, 52 insertions(+)
Signature · 1 line
2.27.0