Skip to content

iavf: Fix return values in driver

Mateusz Palczewski intel-wired-lan 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iavf: stop leaking iavf_status as "errno" valuesdrivers/net/ethernet/intel/iavf/iavf.h drivers/net/ethernet/intel/iavf/iavf_main.c drivers/net/ethernet/intel/iavf/iavf_virtchnl.c+156 -391 reply
2/2iavf: Fix incorrect use of assigning iavf_status to intdrivers/net/ethernet/intel/iavf/iavf_virtchnl.c+68 -921 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchKonrad Jankowski
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Intel-wired-lan] [PATCH net-next v3 0/2] iavf: Fix return values in driver

Several functions in the iAVF core files take status values of the enum iavf_status and convert them into integer values. This leads to confusion as functions return both Linux errno values and status codes intermixed.Fix this by introducing iavf_status_to_errno, a switch that explicitly converts from the status codes into an appropriate error value.
---
v2: Submit this with additional patch introducing iavf_status_to_errno function
v3: Change iavf_poll_virtchnl_msg to int
---
Mateusz Palczewski (2):
iavf-linux: stop leaking iavf_status as "errno" values
iavf: Fix incorrect use of assigning iavf_status to int

 drivers/net/ethernet/intel/iavf/iavf.h        |   5 +-
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 172 ++++++++++++++---
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   | 178 ++++++++----------
 3 files changed, 224 insertions(+), 131 deletions(-)
Signature · 1 line
2.27.0