Skip to content

ice: GTP support in switchdev

Marcin Szycik intel-wired-lan netdev 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest7 patches 3 repliesIn review
  2. v97 patches 3 repliesSuperseded
  3. v87 patches 0 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v77 patches4 repliesSuperseded
v6 posting 2/21 of 7 patches1 replySuperseded
v6 posting 1/27 patches1 replySuperseded
v56 patches3 repliesSuperseded
v4 RFC6 patches6 repliesSuperseded
v3 RFC5 patches7 repliesSuperseded
v2 RFC5 patches2 repliesSuperseded
v1 RFC5 patches0 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7gtp: Allow to create GTP device without FDsdrivers/net/gtp.c include/uapi/linux/if_link.h+85 -170 replies
2/7gtp: Implement GTP echo responsedrivers/net/gtp.c include/net/gtp.h include/uapi/linux/if_link.h+229 -160 replies
3/7gtp: Implement GTP echo requestdrivers/net/gtp.c include/uapi/linux/gtp.h+269 -370 replies
4/7net/sched: Allow flower to match on GTP optionsinclude/net/gtp.h include/uapi/linux/if_tunnel.h include/uapi/linux/pkt_cls.h +1 more+139 -10 replies
5/7gtp: Add support for checking GTP device typeinclude/net/gtp.h+6 -00 replies
6/7ice: Fix FV offset searchingdrivers/net/ethernet/intel/ice/ice_flex_pipe.c drivers/net/ethernet/intel/ice/ice_flex_pipe.h drivers/net/ethernet/intel/ice/ice_switch.c+12 -511 reply
7/7ice: Support GTP-U and GTP-C offload in switchdevdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_flex_pipe.c drivers/net/ethernet/intel/ice/ice_flex_type.h +5 more+760 -182 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchHarald WelteMichal SwiatkowskiSandeep Penigalapati
1/7
2/7R-b T-b
3/7
4/7
5/7R-b
6/7T-b
7/7R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v10 thread

Cover letter [PATCH net-next v10 0/7] ice: GTP support in switchdev

Add support for adding GTP-C and GTP-U filters in switchdev mode.

To create a filter for GTP, create a GTP-type netdev with ip tool, enable hardware offload, add qdisc and add a filter in tc:

ip link add $GTP0 type gtp role <sgsn/ggsn> hsize <hsize> ethtool -K $PF0 hw-tc-offload on
tc qdisc add dev $GTP0 ingress
tc filter add dev $GTP0 ingress prio 1 flower enc_key_id 1337 \
action mirred egress redirect dev $VF1_PR

By default, a filter for GTP-U will be added. To add a filter for GTP-C, specify enc_dst_port = 2123, e.g.:

tc filter add dev $GTP0 ingress prio 1 flower enc_key_id 1337 \
enc_dst_port 2123 action mirred egress redirect dev $VF1_PR

Note: outer IPv6 offload is not supported yet.
Note: GTP-U with no payload offload is not supported yet.

ICE COMMS package is required to create a filter as it contains GTP profiles.

Changes in iproute2 [1] are required to be able to add GTP netdev and use GTP-specific options (QFI and PDU type).

[1] https://lore.kernel.org/netdev/20220211182902.11542-1-wojciech.drewek at intel.com/T
---
v2: Add more CC
v3: Fix mail thread, sorry for spam
v4: Add GTP echo response in gtp module
v5: Change patch order
v6: Add GTP echo request in gtp module
v7: Fix kernel-docs in ice
v8: Remove handling of GTP Echo Response
v9: Add sending of multicast message on GTP Echo Response, fix GTP-C dummy
packet selection
v10: Rebase, fixed most 80 char line limits

Marcin Szycik (1):
ice: Support GTP-U and GTP-C offload in switchdev

Michal Swiatkowski (1):
ice: Fix FV offset searching

Wojciech Drewek (5):
gtp: Allow to create GTP device without FDs
gtp: Implement GTP echo response
gtp: Implement GTP echo request
net/sched: Allow flower to match on GTP options
gtp: Add support for checking GTP device type

 drivers/net/ethernet/intel/ice/ice.h          |   1 +
 .../net/ethernet/intel/ice/ice_flex_pipe.c    |  53 +-
 .../net/ethernet/intel/ice/ice_flex_pipe.h    |   2 +-
 .../net/ethernet/intel/ice/ice_flex_type.h    |   6 +-
 .../ethernet/intel/ice/ice_protocol_type.h    |  19 +
 drivers/net/ethernet/intel/ice/ice_switch.c   | 643 ++++++++++++++++--
 drivers/net/ethernet/intel/ice/ice_switch.h   |   9 +
 drivers/net/ethernet/intel/ice/ice_tc_lib.c   | 105 ++-
 drivers/net/ethernet/intel/ice/ice_tc_lib.h   |   3 +
 drivers/net/gtp.c                             | 565 +++++++++++++--
 include/net/gtp.h                             |  42 ++
 include/uapi/linux/gtp.h                      |   1 +
 include/uapi/linux/if_link.h                  |   2 +
 include/uapi/linux/if_tunnel.h                |   4 +-
 include/uapi/linux/pkt_cls.h                  |  15 +
 net/sched/cls_flower.c                        | 116 ++++
 16 files changed, 1473 insertions(+), 113 deletions(-)
Signature · 1 line
2.35.1