Skip to content

xor: enable auto-vectorization in Clang

Ard Biesheuvel linux-crypto 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 1 replySuperseded
  3. v22 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- revert broken PPC argument rename - doing it fully results in too much pointless churn, and the 'inner' altivec routines are not strictly part of the xor_blocks API anyway

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/xor: make xor prototypes more friendly to compiler vectorizationarch/alpha/include/asm/xor.h arch/arm/include/asm/xor.h arch/arm64/include/asm/xor.h +14 more+381 -2080 replies
2/2crypto: arm/xor - make vectorized C code Clang-friendlyarch/arm/lib/xor-neon.c+3 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNathan ChancellorNick Desaulniers
1/2T-b R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] xor: enable auto-vectorization in Clang

Update the xor_blocks() prototypes so that the compiler understands that the inputs always refer to distinct regions of memory. This is implied by the existing implementations, as they use different granularities for the load/xor/store loops.

With that, we can fix the ARM/Clang version, which refuses to SIMD vectorize otherwise, and throws a spurious warning related to the GCC version being incompatible.

Changes since v3:
- revert broken PPC argument rename - doing it fully results in too much pointless churn, and the 'inner' altivec routines are not strictly part of the xor_blocks API anyway

Changes since v2:
- fix arm64 build after rebase
- name PPC argument names consistently
- add Nick's acks and link tags

Changes since v1:
- fix PPC build
- add Nathan's Tested-by

Cc Nick Desaulniers <[email protected]>
Cc Nathan Chancellor <[email protected]>

Ard Biesheuvel (2):
lib/xor: make xor prototypes more friendly to compiler vectorization
crypto: arm/xor - make vectorized C code Clang-friendly

 arch/alpha/include/asm/xor.h           | 53 ++++++++----
 arch/arm/include/asm/xor.h             | 42 ++++++----
 arch/arm/lib/xor-neon.c                | 12 +--
 arch/arm64/include/asm/xor.h           | 21 +++--
 arch/arm64/lib/xor-neon.c              | 46 +++++++----
 arch/ia64/include/asm/xor.h            | 21 +++--
 arch/powerpc/include/asm/xor_altivec.h | 25 +++---
 arch/powerpc/lib/xor_vmx.c             | 28 ++++---
 arch/powerpc/lib/xor_vmx.h             | 27 ++++---
 arch/powerpc/lib/xor_vmx_glue.c        | 32 ++++----
 arch/s390/lib/xor.c                    | 21 +++--
 arch/sparc/include/asm/xor_32.h        | 21 +++--
 arch/sparc/include/asm/xor_64.h        | 42 ++++++----
 arch/x86/include/asm/xor.h             | 42 ++++++----
 arch/x86/include/asm/xor_32.h          | 42 ++++++----
 arch/x86/include/asm/xor_avx.h         | 21 +++--
 include/asm-generic/xor.h              | 84 +++++++++++++-------
 include/linux/raid/xor.h               | 21 +++--
 18 files changed, 384 insertions(+), 217 deletions(-)
Signature · 1 line
2.30.2