Skip to content

soc: fsl: guts: cleanups and serial_number support

Michael Walle linux-arm-kernel linuxppc-dev lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/27 patches 3 repliesIn review
  2. v2 posting 1/27 patches 2 repliesSuperseded
  3. v17 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- call kfree() in error case, thanks Dan
- add missing of_node_put(np), thanks Dan

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7soc: fsl: guts: machine variable might be unsetdrivers/soc/fsl/guts.c+1 -10 replies
2/7soc: fsl: guts: remove module_exit() and fsl_guts_remove()drivers/soc/fsl/guts.c+1 -140 replies
3/7soc: fsl: guts: embed fsl_guts_get_svr() in probe()drivers/soc/fsl/guts.c+11 -310 replies
4/7soc: fsl: guts: allocate soc_dev_attr on the heapdrivers/soc/fsl/guts.c+21 -190 replies
5/7soc: fsl: guts: use of_root instead of own referencedrivers/soc/fsl/guts.c+4 -80 replies
6/7soc: fsl: guts: drop platform driverdrivers/soc/fsl/guts.c+71 -630 replies
7/7soc: fsl: guts: add serial_number supportdrivers/soc/fsl/guts.c+46 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchArnd Bergmann
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH RESEND v2 0/7] soc: fsl: guts: cleanups and serial_number support

[Resend because of new development cycle. Shawn, can this series get through your tree? Sorry you weren't on CC on the former submissions.]

This series converts the guts driver from a platform driver to just an core_initcall. The driver itself cannot (or rather should never) be unloaded because others depends on detecting the current SoC revision to apply chip errata. Other SoC drivers do it the same way. Overall I got rid of all the global static variables.

The last patch finally adds unique id support to the guts driver. DT binding can be found at:
Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml

changes since v1:
- call kfree() in error case, thanks Dan
- add missing of_node_put(np), thanks Dan

Michael Walle (7):
soc: fsl: guts: machine variable might be unset
soc: fsl: guts: remove module_exit() and fsl_guts_remove()
soc: fsl: guts: embed fsl_guts_get_svr() in probe()
soc: fsl: guts: allocate soc_dev_attr on the heap
soc: fsl: guts: use of_root instead of own reference
soc: fsl: guts: drop platform driver
soc: fsl: guts: add serial_number support

 drivers/soc/fsl/guts.c | 219 ++++++++++++++++++++++-------------------
 1 file changed, 118 insertions(+), 101 deletions(-)
Signature · 1 line
2.30.2