Skip to content

Use drm_clflush* instead of clflush

Michael Cheng dri-devel intel-gfx 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest5 patches 1 replyIn review
  2. v126 patches 15 repliesSuperseded
  3. v116 patches 0 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v106 patches6 repliesSuperseded
v96 patches1 replySuperseded
v86 patches0 repliesSuperseded
v76 patches1 replySuperseded
v66 patches2 repliesSuperseded
v55 patches5 repliesSuperseded
v4 posting 2/24 patches0 repliesSuperseded
v4 posting 1/24 patches0 repliesSuperseded
v24 patches13 repliesSuperseded
v12 patches3 repliesSuperseded

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915/gt: Re-work intel_write_status_pagedrivers/gpu/drm/i915/gt/intel_engine.h+4 -90 replies
2/5drm/i915/gt: Drop invalidate_csb_entriesdrivers/gpu/drm/i915/gt/intel_execlists_submission.c+4 -90 replies
3/5drm/i915/gt: Re-work reset_csbdrivers/gpu/drm/i915/gt/intel_execlists_submission.c+2 -30 replies
4/5drm/i915/: Re-work clflush_write32drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c+3 -50 replies
5/5drm/i915/gt: replace cache_clflush_rangedrivers/gpu/drm/i915/gt/gen8_ppgtt.c drivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/intel_gtt.c +2 more+10 -100 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMatt Roper
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH v13 0/5] Use drm_clflush* instead of clflush

This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures.

v2: s/PAGE_SIZE/sizeof(value) for Re-work intel_write_status_page and added more patches to convert additional clflush/clflushopt to use drm_clflush*. (Michael Cheng)

v3: Drop invalidate_csb_entries and directly invoke drm_clflush_virt_ran

v4: Remove extra memory barriers

v5: s/cache_clflush_range/drm_clflush_virt_range

v6: Fix up "Drop invalidate_csb_entries" to use correct parameters. Also added in arm64 support for drm_clflush_virt_range.

v7: Re-order patches, and use correct macro for dcache flush for arm64.

v8: Remove ifdef for asm/cacheflush.

v9: Rebased

v10: Replaced asm/cacheflush with linux/cacheflush

v11: Correctly get the sizeof certian addresses. Also rebased to the latest.

v12: Drop include of cacheflush.h and use caches_clean_inval_pou instead of dcache_clean_inval_poc, since it is not exported for other modules to use.

v13: Drop arm64 implementation for drm_clflush_virt_range. This series will focus more on making i915 more architecture neutral by abstracting all clflush and clflush opt to the drm layer.

Michael Cheng (5):
drm/i915/gt: Re-work intel_write_status_page
drm/i915/gt: Drop invalidate_csb_entries
drm/i915/gt: Re-work reset_csb
drm/i915/: Re-work clflush_write32
drm/i915/gt: replace cache_clflush_range

 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |  8 +++-----
 drivers/gpu/drm/i915/gt/gen8_ppgtt.c          | 12 +++++------
 drivers/gpu/drm/i915/gt/intel_engine.h        | 13 ++++--------
 .../drm/i915/gt/intel_execlists_submission.c  | 20 +++++++------------
 drivers/gpu/drm/i915/gt/intel_gtt.c           |  2 +-
 drivers/gpu/drm/i915/gt/intel_ppgtt.c         |  2 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  2 +-
 7 files changed, 23 insertions(+), 36 deletions(-)
Signature · 1 line
2.25.1