Skip to content

mptcp: APIs and self-tests for userspace path management

Kishen Maloor mptcp 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest14 patches 6 repliesIn review
  2. v914 patches 4 repliesSuperseded
  3. v814 patches 5 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v714 patches2 repliesSuperseded
v614 patches6 repliesSuperseded
v514 patches5 repliesSuperseded
v413 patches1 replySuperseded
v314 patches9 repliesSuperseded

Changes in v10 from the cover letter

-userspace_pm.sh: Increased sleep time between steps to counter any timing issues with capturing events for verifying the tested behavior. Might resolve test failures in the CI debug build.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14mptcp: allow ADD_ADDR reissuance by userspace PMsnet/mptcp/pm_netlink.c+10 -20 replies
2/14mptcp: handle local addrs announced by userspace PMsnet/mptcp/Makefile net/mptcp/pm.c net/mptcp/pm_netlink.c +3 more+105 -180 replies
3/14mptcp: read attributes of addr entries managed by userspace PMsnet/mptcp/pm_netlink.c net/mptcp/pm_userspace.c net/mptcp/protocol.h +1 more+62 -30 replies
4/14mptcp: netlink: split mptcp_pm_parse_addr into two functionsnet/mptcp/pm_netlink.c+39 -210 replies
5/14mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCEinclude/uapi/linux/mptcp.h net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+88 -130 replies
6/14selftests: mptcp: support MPTCP_PM_CMD_ANNOUNCEtools/testing/selftests/net/mptcp/pm_nl_ctl.c+131 -00 replies
7/14mptcp: netlink: Add MPTCP_PM_CMD_REMOVEinclude/uapi/linux/mptcp.h net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+71 -20 replies
8/14selftests: mptcp: support MPTCP_PM_CMD_REMOVEtools/testing/selftests/net/mptcp/pm_nl_ctl.c+52 -00 replies
9/14mptcp: netlink: allow userspace-driven subflow establishmentinclude/uapi/linux/mptcp.h net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+208 -00 replies
10/14selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_CREATEtools/testing/selftests/net/mptcp/pm_nl_ctl.c+129 -00 replies
11/14selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_DESTROYtools/testing/selftests/net/mptcp/pm_nl_ctl.c+115 -00 replies
12/14selftests: mptcp: capture netlink eventstools/testing/selftests/net/mptcp/pm_nl_ctl.c+157 -70 replies
13/14selftests: mptcp: create listeners to receive MPJstools/testing/selftests/net/mptcp/pm_nl_ctl.c+54 -00 replies
14/14selftests: mptcp: functional tests for the userspace PM typetools/testing/selftests/net/mptcp/userspace_pm.sh+779 -03 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH mptcp-next v10 00/14] mptcp: APIs and self-tests for userspace path management

This patch series brings together the base functionality and new netlink APIs for flexible path management from userspace. Further it extends the MPTCP self-testing framework to support the new netlink APIs along with the ability to capture MPTCP netlink events to aid in functional/behavioral validations. Lastly, it adds a self-testing script with a suite of test cases covering the entire range of the new userspace path management capabilities.

Note: This series depends on the prior patchset "mptcp: fixes and enhancements related to path management".

v5:
-Primary change over v4 is the reliance on userspace managed listener sockets for receiving MPJ requests. -Addressed CI reported issues.

v6:
-Put all distinct userspace PM related code into a separate compilation
unit: pm_userspace.c.
-Made a few internal helpers non-static (now declared in protocol.h) to facilitate the above change.
-Use the pm spinlock instead of mptcp_data_lock() to synchronize access to the per-msk local_addr_list.

v7:
-Move userspace PM specific handling from pm_netlink
into mptcp_userspace_pm_get_local_id()
and mptcp_userspace_pm_get_flags_and_ifindex_by_id() in pm_userspace.

v8:
-Add copyright notice to pm_userspace.c.

v9:
-userspace_pm.sh: Mitigate possible buffering issues with CI.

v10:
-userspace_pm.sh: Increased sleep time between steps to counter any timing issues with capturing events for verifying the tested behavior. Might resolve test failures in the CI debug build.

Florian Westphal (2):
mptcp: netlink: split mptcp_pm_parse_addr into two functions
mptcp: netlink: allow userspace-driven subflow establishment

Kishen Maloor (12):
mptcp: allow ADD_ADDR reissuance by userspace PMs
mptcp: handle local addrs announced by userspace PMs
mptcp: read attributes of addr entries managed by userspace PMs
mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE
selftests: mptcp: support MPTCP_PM_CMD_ANNOUNCE
mptcp: netlink: Add MPTCP_PM_CMD_REMOVE
selftests: mptcp: support MPTCP_PM_CMD_REMOVE
selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_CREATE
selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_DESTROY
selftests: mptcp: capture netlink events
selftests: mptcp: create listeners to receive MPJs
selftests: mptcp: functional tests for the userspace PM type

 include/uapi/linux/mptcp.h                    |   7 +
 net/mptcp/Makefile                            |   2 +-
 net/mptcp/pm.c                                |   1 +
 net/mptcp/pm_netlink.c                        | 169 ++--
 net/mptcp/pm_userspace.c                      | 415 ++++++++++
 net/mptcp/protocol.c                          |   1 +
 net/mptcp/protocol.h                          |  39 +-
 net/mptcp/subflow.c                           |   2 +-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 645 ++++++++++++++-
 .../selftests/net/mptcp/userspace_pm.sh       | 779 ++++++++++++++++++
 10 files changed, 1997 insertions(+), 63 deletions(-)
 create mode 100644 net/mptcp/pm_userspace.c
 create mode 100755 tools/testing/selftests/net/mptcp/userspace_pm.sh

base-commit: 812de90f114c9234a4ebc80058e71250e552ce5f --
2.31.1