Skip to content

nvme: add helpers and remove duplicate code

Chaitanya Kulkarni linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9nvme-fc: add a helper to initialize connect_qdrivers/nvme/host/fc.c drivers/nvme/host/nvme.h+10 -43 replies
2/9nvme-rdma: use helper to initialize connect_qdrivers/nvme/host/rdma.c+3 -41 reply
3/9nvme-tcp: use helper to initialize connect_qdrivers/nvme/host/tcp.c+2 -41 reply
4/9nvme-loop: use helper to initialize connect_qdrivers/nvme/target/loop.c+2 -41 reply
5/9nvme-fc: centralize admin tagset initializationdrivers/nvme/host/fc.c drivers/nvme/host/nvme.h+20 -95 replies
6/9nvme-pci: use helper for tagset initializationdrivers/nvme/host/pci.c+3 -80 replies
7/9nvme-rdma: use helper for tagset initializationdrivers/nvme/host/rdma.c+3 -90 replies
8/9nvme-tcp: use helper for tagset initializationdrivers/nvme/host/tcp.c+3 -90 replies
9/9nvme-loop: use helper for tagset initializationdrivers/nvme/target/loop.c+4 -90 replies

Reviews trailers per patch

4 of 9 patches have a Reviewed-by or Acked-by.

PatchSagi Grimberg
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] nvme: add helpers and remove duplicate code

From: Chaitanya Kulkarni <[email protected]>

HI,

Instead of opencoding connect_q initialization/error handling and the initialization of the admin tagset, add common helpers to remove the ducplicate code in different transports.

-ck

Chaitanya Kulkarni (9):
nvme-fc: add a helper to initialize connect_q
nvme-rdma: use helper to initialize connect_q
nvme-tcp: use helper to initialize connect_q
nvme-loop: use helper to initialize connect_q
nvme-fc: centralize admin tagset initialization
nvme-pci: use helper for tagset initialization
nvme-rdma: use helper for tagset initialization
nvme-tcp: use helper for tagset initialization
nvme-loop: use helper for tagset initialization

 drivers/nvme/host/fc.c     | 18 +++++-------------
 drivers/nvme/host/nvme.h   | 25 +++++++++++++++++++++++++
 drivers/nvme/host/pci.c    | 11 +++--------
 drivers/nvme/host/rdma.c   | 19 ++++++-------------
 drivers/nvme/host/tcp.c    | 18 +++++-------------
 drivers/nvme/target/loop.c | 19 ++++++-------------
 6 files changed, 50 insertions(+), 60 deletions(-)
Signature · 1 line
2.29.0