Skip to content

EFI/menu: Do not print messages when autobooting with TIMEOUT_STYLE_HIDDEN

Hans de Goede grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2normal/menu: Don't show "Booting `%s'" msg when auto-booting with TIMEOUT_STYLE_HIDDENgrub-core/normal/menu.c+16 -81 reply
2/2EFI: suppress the "Welcome to GRUB!" message in EFI buildsgrub-core/kern/main.c+3 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRobbie HarwoodDaniel Kiper
SeriesR-b R-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] EFI/menu: Do not print messages when autobooting with TIMEOUT_STYLE_HIDDEN

Hi All,

This series in essence is a renewed attempt to get grub to really be truly hidden when autobooting with TIMEOUT_STYLE_HIDDEN.

This is something which multiple big Linux distributions want, this is a minimized version of my previous attempt from March 2018:
https://lists.gnu.org/archive/html/grub-devel/2018-03/msg00126.html
With some discussion about this patch in April 2018:
https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00009.html

The first patch silences the notify_booting() callback from grub-core/normal/menu.c based on the timeout_style (1), as suggested in the original discussion.

After that there is just one message left, from grub-core/kern/main.c which is printed before the config file loads. When timeout_style is not set to hidden this will only show very briefly to then be replaced by the menu / countdown; and with timeout_style=hidden we actually want it to behave the same as any other grub messages and have it hidden. The second patch makes this happen by just disabling the logging of the message for EFI builds.

This also fixes the message briefly flashing by (in an ugly manner because of the "flash" part) when timeout_style!=hidden.

Regards,

Hans

1) It is only silenced when autobooting with TIMEOUT_STYLE_HIDDEN

Hans de Goede (2):
normal/menu: Don't show "Booting `%s'" msg when auto-booting with
TIMEOUT_STYLE_HIDDEN
EFI: suppress the "Welcome to GRUB!" message in EFI builds

 grub-core/kern/main.c   |  3 +++
 grub-core/normal/menu.c | 25 +++++++++++++++++--------
 2 files changed, 20 insertions(+), 8 deletions(-)
Signature · 1 line
2.33.1