Skip to content

drm/i915: Refactor the display power domain mappings

Imre Deak intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 2 repliesIn review
  2. v226 patches 7 repliesSuperseded
  3. v119 patches 9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18drm/i915: Move per-platform power well hooks to intel_display_power_well.cdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/display/intel_display_power_well.c +3 more+1846 -17991 reply
2/18drm/i915: Unexport the for_each_power_well() macrosdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/display/intel_display_power_well.h+20 -200 replies
3/18drm/i915: Move the power domain->well mappings to intel_display_power_map.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power_map.c +1 more+2168 -22571 reply
4/18drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfielddrivers/gpu/drm/i915/display/intel_display_power_map.c drivers/gpu/drm/i915/display/intel_display_power_well.c drivers/gpu/drm/i915/display/intel_display_power_well.h+14 -150 replies
5/18drm/i915: Move the HSW power well flags to a common bitfielddrivers/gpu/drm/i915/display/intel_display_power_map.c drivers/gpu/drm/i915/display/intel_display_power_well.c drivers/gpu/drm/i915/display/intel_display_power_well.h+104 -1030 replies
6/18drm/i915: Rename the power domain names to end with pipes/portsdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c +3 more+205 -2050 replies
7/18drm/i915: Sanitize the power well namesdrivers/gpu/drm/i915/display/intel_display_power_map.c+127 -1270 replies
8/18drm/i915: Convert the power well descriptor domain mask to an array of domainsdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power_map.c drivers/gpu/drm/i915/display/intel_display_power_well.c +1 more+754 -6850 replies
9/18drm/i915: Convert the u64 power well domains mask to a bitmapdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h +3 more+116 -880 replies
10/18drm/i915: Simplify power well definitions by adding power well instancesdrivers/gpu/drm/i915/display/intel_display_power_map.c drivers/gpu/drm/i915/display/intel_display_power_well.c drivers/gpu/drm/i915/display/intel_display_power_well.h+505 -11300 replies
11/18drm/i915: Allow platforms to share power well descriptorsdrivers/gpu/drm/i915/display/intel_display_power_map.c+122 -1590 replies
12/18drm/i915: Simplify the DG1 power well descriptorsdrivers/gpu/drm/i915/display/intel_display_power_map.c+7 -170 replies
13/18drm/i915: Sanitize the ADL-S power well definitiondrivers/gpu/drm/i915/display/intel_display_power_map.c+39 -300 replies
14/18drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platformdrivers/gpu/drm/i915/display/g4x_dp.c drivers/gpu/drm/i915/display/g4x_hdmi.c drivers/gpu/drm/i915/display/intel_ddi.c +5 more+235 -890 replies
15/18drm/i915: Remove the aliasing of power domain enum valuesdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h+67 -430 replies
16/18drm/i915: Remove the ICL specific TBT power domainsdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/display/intel_display_power_map.c+9 -210 replies
17/18drm/i915: Remove duplicate DDI/AUX power domain mappingsdrivers/gpu/drm/i915/display/intel_display_power_map.c+31 -580 replies
18/18drm/i915: Remove the XELPD specific AUX and DDI power domainsdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/display/intel_display_power_map.c+11 -380 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchJouni Högander
1/18R-b
2/18R-b
3/18R-b R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Intel-gfx] [PATCH v3 00/18] drm/i915: Refactor the display power domain mappings

This is v3 of the second half of [1], rebased on drm-tip (containing the first half [2]), addressing the review comments from Jouni and with a minor documentation/rename change in patch 3.

[1] https://patchwork.freedesktop.org/series/99476/
[2] https://patchwork.freedesktop.org/series/100591/

Cc Jouni Högander <[email protected]>
Cc Jani Nikula <[email protected]>

Imre Deak (18):
drm/i915: Move per-platform power well hooks to intel_display_power_well.c drm/i915: Unexport the for_each_power_well() macros
drm/i915: Move the power domain->well mappings to intel_display_power_map.c drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield drm/i915: Move the HSW power well flags to a common bitfield drm/i915: Rename the power domain names to end with pipes/ports drm/i915: Sanitize the power well names
drm/i915: Convert the power well descriptor domain mask to an array of domains drm/i915: Convert the u64 power well domains mask to a bitmap drm/i915: Simplify power well definitions by adding power well instances drm/i915: Allow platforms to share power well descriptors drm/i915: Simplify the DG1 power well descriptors
drm/i915: Sanitize the ADL-S power well definition
drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform drm/i915: Remove the aliasing of power domain enum values drm/i915: Remove the ICL specific TBT power domains
drm/i915: Remove duplicate DDI/AUX power domain mappings
drm/i915: Remove the XELPD specific AUX and DDI power domains

 drivers/gpu/drm/i915/Makefile                 |    1 +
 drivers/gpu/drm/i915/display/g4x_dp.c         |    3 +-
 drivers/gpu/drm/i915/display/g4x_hdmi.c       |    3 +-
 drivers/gpu/drm/i915/display/icl_dsi.c        |    8 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |    6 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  150 +-
 drivers/gpu/drm/i915/display/intel_display.h  |    4 +-
 .../drm/i915/display/intel_display_power.c    | 4477 ++---------------
 .../drm/i915/display/intel_display_power.h    |  122 +-
 .../i915/display/intel_display_power_map.c    | 1501 ++++++
 .../i915/display/intel_display_power_map.h    |   14 +
 .../i915/display/intel_display_power_well.c   | 1838 ++++++-
 .../i915/display/intel_display_power_well.h   |  132 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |    1 +
 drivers/gpu/drm/i915/display/intel_pps.c      |    1 +
 drivers/gpu/drm/i915/display/intel_tc.c       |    5 +-
 16 files changed, 3881 insertions(+), 4385 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_map.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_map.h
Signature · 1 line
2.30.2