Skip to content

ASoC: SOF: dma-trace: Change trace_init() ops parameter list

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: SOF: intel: hda-trace: Pass the dma buffer pointer to hda_dsp_trace_preparesound/soc/sof/intel/hda-trace.c+3 -40 replies
2/2ASoC: SOF: dma-trace: Pass pointer to params_ext struct in trace_init()sound/soc/sof/amd/acp-trace.c sound/soc/sof/amd/acp.h sound/soc/sof/intel/hda-trace.c +4 more+23 -390 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartRanjani Sridharan
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: SOF: dma-trace: Change trace_init() ops parameter list

Hi,

the DMA trace implementation on AMD platform assumes that the stream_tag pointer is pointing the stream_tag member of struct sof_ipc_dma_trace_params_ext, which is true at the moment, but it can not be guarantied and a change in the dtrace core can cause out of bound accesses for AMD.

For this reason, change the API to pass the struct itself which will remove the assumption and makes it clear from both sides what is expected to be sent via the parameter list.

This opens up a window to clean up the intel and AMD implementation at the same time.

Regards,
Peter
---

Peter Ujfalusi (2):
ASoC: SOF: intel: hda-trace: Pass the dma buffer pointer to
hda_dsp_trace_prepare
ASoC: SOF: dma-trace: Pass pointer to params_ext struct in
trace_init()

 sound/soc/sof/amd/acp-trace.c   | 38 ++++++++-------------------------
 sound/soc/sof/amd/acp.h         |  3 ++-
 sound/soc/sof/intel/hda-trace.c | 17 ++++++++-------
 sound/soc/sof/intel/hda.h       |  3 ++-
 sound/soc/sof/ops.h             |  4 ++--
 sound/soc/sof/sof-priv.h        |  2 +-
 sound/soc/sof/trace.c           |  2 +-
 7 files changed, 26 insertions(+), 43 deletions(-)
Signature · 1 line
2.35.0