Skip to content

Pine64 PinePhone keyboard support

Samuel Holland linux-arm-kernel linux-devicetree linux-input linux-sunxi lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 4 repliesIn review
  2. v34 patches 1 replySuperseded
  3. v24 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches12 repliesSuperseded

Changes in v4 from the cover letter

- Rebase to resolve MAINTAINERS merge conflict
- Add missing newlines in error messages

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dt-bindings: input: Add the PinePhone keyboard bindingDocumentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml+66 -00 replies
2/4Input: pinephone-keyboard - Add PinePhone keyboard driverMAINTAINERS drivers/input/keyboard/Kconfig drivers/input/keyboard/Makefile +1 more+382 -03 replies
3/4Input: pinephone-keyboard - Support the proxied I2C busdrivers/input/keyboard/pinephone-keyboard.c+73 -01 reply
4/4arm64: dts: allwinner: pinephone: Add keyboardarch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi+18 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] Pine64 PinePhone keyboard support

This series adds support for the official keyboard case for the Pine64 PinePhone and PinePhone Pro. This accessory contains a keyboard MCU and an IP5209 power bank IC. The keyboard MCU firmware[0] is free software. It exposes the keyboard scan matrix over I2C, and also provides commands for SMBus access to the IP5209. In order to keep the IP5209 driver (CONFIG_IP5XXX_POWER) generic, this is modeled as a child I2C bus.

[0]: https://megous.com/git/pinephone-keyboard/about/

Changes in v4:
- Rebase to resolve MAINTAINERS merge conflict
- Add missing newlines in error messages

Changes in v3:
- Replace unevaluatedProperties with additionalProperties
- Rename i2c-bus to i2c
- Rename i2c-bus to i2c

Changes in v2:
- Drop keymap DT properties
- Add vbat-supply property
- Fix missing key release events when FN state changes
- Add VBAT consumer to ensure enough power is available for the MCU
- Use a single fixed-size, fixed-contents keymap for both layers

Samuel Holland (4):
dt-bindings: input: Add the PinePhone keyboard binding
Input: pinephone-keyboard - Add PinePhone keyboard driver
Input: pinephone-keyboard - Support the proxied I2C bus [DO NOT MERGE] arm64: dts: allwinner: pinephone: Add keyboard

 .../input/pine64,pinephone-keyboard.yaml      |  66 +++
 MAINTAINERS                                   |   6 +
 .../dts/allwinner/sun50i-a64-pinephone.dtsi   |  18 +
 drivers/input/keyboard/Kconfig                |  10 +
 drivers/input/keyboard/Makefile               |   1 +
 drivers/input/keyboard/pinephone-keyboard.c   | 438 ++++++++++++++++++
 6 files changed, 539 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml
 create mode 100644 drivers/input/keyboard/pinephone-keyboard.c
Signature · 1 line
2.35.1