Skip to content

Flight Data Recorder Update

Steve Dickson linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Makefile: cleaned up the usage of RPMBUILD_DIRMakefile+4 -40 replies
2/5fdr.spec: logrotate clean upbuildrpm/1.3/fdr.spec+5 -40 replies
3/5systemd: rename service file.buildrpm/1.3/fdr.spec fdrd.man fdrd.service+6 -60 replies
4/5saveto verb: Document updatedfdrd.man samples/nfs+9 -00 replies
5/5configs: Add an nfsall.conf config filebuildrpm/1.3/fdr.spec configs/nfsall.conf+325 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Flight Data Recorder Update

Here a few updates to the FDR package that
will allow it to work out of the box when
the RPM is install... Kinda.

When the rpm is installed, the daemon is not enable or started and the config file is not enabled. But it makes much easier set a tracepoint. Uncomment the needed tracepoint and start the fdrd daemon. Then do tail -f on /var/log/nfs.log.

The package is very light weight: one daemon, two config files and one example file. The config file that is installed has all of the nfs,nfsv4 and sunrpc tracepoints, commented out.

The first 4 patches are clean up... Making things work right out of the box and conforming to current presidencies. The last patch, installing an nfsall.conf config, could be questionable. Do the maintainers want to maintain config files or have the distros do it?

I guess the bottom line is this. At the last bakeathon we talked about moving away from rpcdebug setting dprintks to tracepoints (which is a good thing IMHO). Now, it is not clear how it can be done, but I'm hoping this is the first step in that direction.

Steve Dickson (5):
Makefile: cleaned up the usage of RPMBUILD_DIR fdr.spec: logrotate clean up
systemd: rename service file.
saveto verb: Document updated
configs: Add an nfsall.conf config file

 Makefile                    |   8 +-
 buildrpm/1.3/fdr.spec       |  25 ++-
 configs/nfsall.conf         | 319 ++++++++++++++++++++++++++++++++++++
 fdrd.man                    |   9 +-
 fdr.service => fdrd.service |   0
 samples/nfs                 |   2 +
 6 files changed, 349 insertions(+), 14 deletions(-)
 create mode 100644 configs/nfsall.conf
 rename fdr.service => fdrd.service (100%)
Signature · 1 line
2.34.1