Skip to content

2nd set of IIO export namespaces

Jonathan Cameron linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16iio:adc:ad_sigma_delta: Move exports into IIO_AD_SIGMA_DELTA namespacedrivers/iio/adc/ad7124.c drivers/iio/adc/ad7192.c drivers/iio/adc/ad7780.c +3 more+15 -100 replies
2/16iio:adc:ad7091r: Move exports into IIO_AD7091R namespace.drivers/iio/adc/ad7091r-base.c drivers/iio/adc/ad7091r5.c+3 -21 reply
3/16iio:adc:ad76060: Move exports into IIO_AD7606 namespace.drivers/iio/adc/ad7606.c drivers/iio/adc/ad7606_par.c drivers/iio/adc/ad7606_spi.c+4 -20 replies
4/16iio:common:meas-spec: Move exports into IIO_MEAS_SPEC_SENSORSdrivers/iio/common/ms_sensors/ms_sensors_i2c.c drivers/iio/humidity/htu21.c drivers/iio/pressure/ms5637.c +2 more+16 -120 replies
5/16iio:common:ssp_sensors: Move exports into IIO_SSP_SENSORS namespacedrivers/iio/accel/ssp_accel_sensor.c drivers/iio/common/ssp_sensors/ssp_dev.c drivers/iio/common/ssp_sensors/ssp_iio.c +1 more+11 -80 replies
6/16iio:dac:ad5592r: Move exports into IIO_AD5592R namespacedrivers/iio/dac/ad5592r-base.c drivers/iio/dac/ad5592r.c drivers/iio/dac/ad5593r.c+4 -21 reply
7/16iio:dac:ad5686: Move exports into IIO_AD5686 namespacedrivers/iio/dac/ad5686-spi.c drivers/iio/dac/ad5686.c drivers/iio/dac/ad5696-i2c.c+4 -20 replies
8/16iio:imu:adis: Move exports into IIO_ADISLIB namespacedrivers/iio/accel/adis16201.c drivers/iio/accel/adis16209.c drivers/iio/gyro/adis16136.c +10 more+23 -130 replies
9/16iio:pressure:zpa2326: Move exports into IIO_ZPA2326 namespacedrivers/iio/pressure/zpa2326.c drivers/iio/pressure/zpa2326_i2c.c drivers/iio/pressure/zpa2326_spi.c+8 -60 replies
10/16iio:pressure:ms5611: Move exports into IIO_MS5611 namespacedrivers/iio/pressure/ms5611_core.c drivers/iio/pressure/ms5611_i2c.c drivers/iio/pressure/ms5611_spi.c+4 -20 replies
11/16iio:pressure:mpl115: Move exports into IIO_MPL115 namespacedrivers/iio/pressure/mpl115.c drivers/iio/pressure/mpl115_i2c.c drivers/iio/pressure/mpl115_spi.c+3 -10 replies
12/16iio:magnetometer:rm3100: Move exports to IIO_RM3100 namespacedrivers/iio/magnetometer/rm3100-core.c drivers/iio/magnetometer/rm3100-i2c.c drivers/iio/magnetometer/rm3100-spi.c+6 -40 replies
13/16iio:magnetometer:bmc150: Move exports to IIO_BMC150_MAGN namespacedrivers/iio/magnetometer/bmc150_magn.c drivers/iio/magnetometer/bmc150_magn_i2c.c drivers/iio/magnetometer/bmc150_magn_spi.c+6 -40 replies
14/16iio:magnetometer:hmc5843: Move exports to IIO_HMC5843 namespacedrivers/iio/magnetometer/hmc5843_core.c drivers/iio/magnetometer/hmc5843_i2c.c drivers/iio/magnetometer/hmc5843_spi.c+6 -40 replies
15/16iio:light:st_uvis25: Move exports to IIO_UVIS25 namespacedrivers/iio/light/st_uvis25_core.c drivers/iio/light/st_uvis25_i2c.c drivers/iio/light/st_uvis25_spi.c+4 -20 replies
16/16iio:chemical:bme680: Move exports to IIO_BME680 namespacedrivers/iio/chemical/bme680_core.c drivers/iio/chemical/bme680_i2c.c drivers/iio/chemical/bme680_spi.c+4 -20 replies

Reviews trailers per patch

2 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoPaul Cercueil
SeriesR-b
1/16
2/16R-b
3/16
4/16
5/16
6/16R-b
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] 2nd set of IIO export namespaces

From: Jonathan Cameron <[email protected]>

Whilst I'm still looking for additional review on the first set, I'll take the quiet as meaning no one objects and send out a second set. Note that I don't have anyone cc'd on some of these because I couldn't immediately figure out who was still active and familiar with the drivers. As these should be simple to review, please take a look at as many as you have time for!

Here's the reasoning as per the first set cover letter. Note that we have some clashes with patches that I'd like to clean up the handling of dev_pm_ops and CONFIG_PM* guards so for now I've dropped those cases from this series.

https://lwn.net/Articles/760045/ provides a good overview of this feature and why it might be used. In this particular case we fall under the multi module case. For each group of modules, I've moved the exports into an independent namespace.

Whilst I'm not entirely sure it is worth the noise of moving the main IIO exports into a namespace, it is definitely worthwhile for these small clusters of related modules (typically a core + i2c and spi modules).

I've just done those within drivers/accel (including all of st-sensors as I did not want to do that piecemeal) as an initial set to get feedback on what people think of the approach and in particular naming of the namespaces.

As you can see it is a straight forward change to makes so I'll do the rest of the IIO drivers once we are agreed on the generic details. Note that I'll be expecting this for any new cases of this pattern going forwards.

Includes a small diversion in st-sensors where we had a bunch of duplicated MODULE_* macros for some of the core modules which were made up of multiple c files.

Cc Himanshu Jha <[email protected]>
Cc Song Qiang <[email protected]>
Cc Tomasz Duszynski <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Song Bao Hua (Barry Song) <[email protected]>
Cc Paul Cercueil <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc William Markezana <[email protected]>
Cc Ludovic Tancerel <[email protected]>
Cc Renato Lui Geh <[email protected]>
Cc Michael Hennerich <[email protected]>

Jonathan Cameron (16):
iio:adc:ad_sigma_delta: Move exports into IIO_AD_SIGMA_DELTA namespace iio:adc:ad7091r: Move exports into IIO_AD7091R namespace. iio:adc:ad76060: Move exports into IIO_AD7606 namespace. iio:common:meas-spec: Move exports into IIO_MEAS_SPEC_SENSORS iio:common:ssp_sensors: Move exports into IIO_SSP_SENSORS namespace iio:dac:ad5592r: Move exports into IIO_AD5592R namespace iio:dac:ad5686: Move exports into IIO_AD5686 namespace iio:imu:adis: Move exports into IIO_ADISLIB namespace iio:pressure:zpa2326: Move exports into IIO_ZPA2326 namespace iio:pressure:ms5611: Move exports into IIO_MS5611 namespace iio:pressure:mpl115: Move exports into IIO_MPL115 namespace iio:magnetometer:rm3100: Move exports to IIO_RM3100 namespace iio:magnetometer:bmc150: Move exports to IIO_BMC150_MAGN namespace iio:magnetometer:hmc5843: Move exports to IIO_HMC5843 namespace iio:light:st_uvis25: Move exports to IIO_UVIS25 namespace iio:chemical:bme680: Move exports to IIO_BME680 namespace

 drivers/iio/accel/adis16201.c                 |  1 +
 drivers/iio/accel/adis16209.c                 |  1 +
 drivers/iio/accel/ssp_accel_sensor.c          |  1 +
 drivers/iio/adc/ad7091r-base.c                |  4 ++--
 drivers/iio/adc/ad7091r5.c                    |  1 +
 drivers/iio/adc/ad7124.c                      |  1 +
 drivers/iio/adc/ad7192.c                      |  1 +
 drivers/iio/adc/ad7606.c                      |  4 ++--
 drivers/iio/adc/ad7606_par.c                  |  1 +
 drivers/iio/adc/ad7606_spi.c                  |  1 +
 drivers/iio/adc/ad7780.c                      |  1 +
 drivers/iio/adc/ad7791.c                      |  1 +
 drivers/iio/adc/ad7793.c                      |  1 +
 drivers/iio/adc/ad_sigma_delta.c              | 20 ++++++++--------
 drivers/iio/chemical/bme680_core.c            |  4 ++--
 drivers/iio/chemical/bme680_i2c.c             |  1 +
 drivers/iio/chemical/bme680_spi.c             |  1 +
 .../iio/common/ms_sensors/ms_sensors_i2c.c    | 24 +++++++++----------
 drivers/iio/common/ssp_sensors/ssp_dev.c      | 10 ++++----
 drivers/iio/common/ssp_sensors/ssp_iio.c      |  7 +++---
 drivers/iio/dac/ad5592r-base.c                |  4 ++--
 drivers/iio/dac/ad5592r.c                     |  1 +
 drivers/iio/dac/ad5593r.c                     |  1 +
 drivers/iio/dac/ad5686-spi.c                  |  1 +
 drivers/iio/dac/ad5686.c                      |  4 ++--
 drivers/iio/dac/ad5696-i2c.c                  |  1 +
 drivers/iio/gyro/adis16136.c                  |  1 +
 drivers/iio/gyro/adis16260.c                  |  1 +
 drivers/iio/gyro/ssp_gyro_sensor.c            |  1 +
 drivers/iio/humidity/htu21.c                  |  1 +
 drivers/iio/imu/adis.c                        | 20 ++++++++--------
 drivers/iio/imu/adis16400.c                   |  1 +
 drivers/iio/imu/adis16460.c                   |  1 +
 drivers/iio/imu/adis16475.c                   |  1 +
 drivers/iio/imu/adis16480.c                   |  1 +
 drivers/iio/imu/adis_buffer.c                 |  4 ++--
 drivers/iio/imu/adis_trigger.c                |  2 +-
 drivers/iio/light/st_uvis25_core.c            |  4 ++--
 drivers/iio/light/st_uvis25_i2c.c             |  1 +
 drivers/iio/light/st_uvis25_spi.c             |  1 +
 drivers/iio/magnetometer/bmc150_magn.c        |  8 +++----
 drivers/iio/magnetometer/bmc150_magn_i2c.c    |  1 +
 drivers/iio/magnetometer/bmc150_magn_spi.c    |  1 +
 drivers/iio/magnetometer/hmc5843_core.c       |  8 +++----
 drivers/iio/magnetometer/hmc5843_i2c.c        |  1 +
 drivers/iio/magnetometer/hmc5843_spi.c        |  1 +
 drivers/iio/magnetometer/rm3100-core.c        |  8 +++----
 drivers/iio/magnetometer/rm3100-i2c.c         |  1 +
 drivers/iio/magnetometer/rm3100-spi.c         |  1 +
 drivers/iio/pressure/mpl115.c                 |  2 +-
 drivers/iio/pressure/mpl115_i2c.c             |  1 +
 drivers/iio/pressure/mpl115_spi.c             |  1 +
 drivers/iio/pressure/ms5611_core.c            |  4 ++--
 drivers/iio/pressure/ms5611_i2c.c             |  1 +
 drivers/iio/pressure/ms5611_spi.c             |  1 +
 drivers/iio/pressure/ms5637.c                 |  1 +
 drivers/iio/pressure/zpa2326.c                | 12 +++++-----
 drivers/iio/pressure/zpa2326_i2c.c            |  1 +
 drivers/iio/pressure/zpa2326_spi.c            |  1 +
 drivers/iio/temperature/tsys01.c              |  1 +
 drivers/iio/temperature/tsys02d.c             |  1 +
 drivers/staging/iio/accel/adis16203.c         |  1 +
 drivers/staging/iio/accel/adis16240.c         |  1 +
 63 files changed, 121 insertions(+), 76 deletions(-)
Signature · 1 line
2.35.1