Skip to content

hw/arm: zynqmp: Add CRF and APU control to support PSCI

Edgar E. Iglesias qemu-arm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesIn review
  2. v26 patches 6 repliesSuperseded
  3. v16 patches 19 repliesSuperseded

Changes in v3 from the cover letter

* Make RVBAR_ELx register reflect updated rvbar
* Sample rvbar prop at reset
* Remove setting of minimum_version_id_old
* Use OBJECT_DECLARE_SIMPLE_TYPE

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/arm/xlnx-zynqmp: Add an unimplemented SERDES areahw/arm/xlnx-zynqmp.c include/hw/arm/xlnx-zynqmp.h+6 -10 replies
2/6target/arm: Make rvbar settable after realizetarget/arm/cpu.c target/arm/cpu.h target/arm/helper.c+16 -90 replies
3/6hw/misc: Add a model of the Xilinx ZynqMP CRFhw/misc/meson.build hw/misc/xlnx-zynqmp-crf.c include/hw/misc/xlnx-zynqmp-crf.h+478 -00 replies
4/6hw/arm/xlnx-zynqmp: Connect the ZynqMP CRFhw/arm/xlnx-zynqmp.c include/hw/arm/xlnx-zynqmp.h+18 -00 replies
5/6hw/misc: Add a model of the Xilinx ZynqMP APU Controlhw/misc/meson.build hw/misc/xlnx-zynqmp-apu-ctrl.c include/hw/misc/xlnx-zynqmp-apu-ctrl.h+347 -00 replies
6/6hw/arm/xlnx-zynqmp: Connect the ZynqMP APU Controlhw/arm/xlnx-zynqmp.c include/hw/arm/xlnx-zynqmp.h+26 -30 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéFrancisco IglesiasPeter MaydellLuc Michel
1/6R-b R-b
2/6
3/6R-b R-b
4/6R-b R-b R-b
5/6R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/6] hw/arm: zynqmp: Add CRF and APU control to support PSCI

From: "Edgar E. Iglesias" <[email protected]>

This adds the necessary modeling to support some of our firmware tests at EL3 implementing PSCI (TBM). These are the test-cases that were previously relying on QEMU's builtin PSCI emulation.

Cheers,
Edgar

ChangeLog:

v2 -> v3:
* Make RVBAR_ELx register reflect updated rvbar
* Sample rvbar prop at reset
* Remove setting of minimum_version_id_old
* Use OBJECT_DECLARE_SIMPLE_TYPE

v1 -> v2:
* crf: Change APU_MAX_CPU to CRF_MAX_CPU
* crf: Remove empty interfaces
* crf: Add include guards
* apu-ctrl: Change NUM_CPUS to APU_MAX_CPU
* apu-ctrl: Fix indentation
* apu-ctrl: Remove empty interfaces
* apu-ctrl: Add include guards
* xlnx-zynqmp: Add comment clarifying SER/DESerializer

Edgar E. Iglesias (6):
hw/arm/xlnx-zynqmp: Add an unimplemented SERDES area target/arm: Make rvbar settable after realize hw/misc: Add a model of the Xilinx ZynqMP CRF hw/arm/xlnx-zynqmp: Connect the ZynqMP CRF hw/misc: Add a model of the Xilinx ZynqMP APU Control hw/arm/xlnx-zynqmp: Connect the ZynqMP APU Control

 include/hw/arm/xlnx-zynqmp.h           |   4 +
 include/hw/misc/xlnx-zynqmp-apu-ctrl.h |  93 +++++++++
 include/hw/misc/xlnx-zynqmp-crf.h      | 211 ++++++++++++++++++++
 target/arm/cpu.h                       |   3 +-
 hw/arm/xlnx-zynqmp.c                   |  46 ++++-
 hw/misc/xlnx-zynqmp-apu-ctrl.c         | 253 +++++++++++++++++++++++
 hw/misc/xlnx-zynqmp-crf.c              | 266 +++++++++++++++++++++++++
 target/arm/cpu.c                       |  12 +-
 target/arm/helper.c                    |  10 +-
 hw/misc/meson.build                    |   2 +
 10 files changed, 889 insertions(+), 11 deletions(-)
 create mode 100644 include/hw/misc/xlnx-zynqmp-apu-ctrl.h
 create mode 100644 include/hw/misc/xlnx-zynqmp-crf.h
 create mode 100644 hw/misc/xlnx-zynqmp-apu-ctrl.c
 create mode 100644 hw/misc/xlnx-zynqmp-crf.c
Signature · 1 line
2.25.1