Skip to content

mm/gup: some cleanups

John Hubbard linux-mm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 3 repliesIn review
  2. v45 patches 7 repliesApplied 5/5
  3. v34 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches3 repliesSuperseded
v14 patches9 repliesSuperseded

Changes in v5 from the cover letter

* Patch 1: reflowed the commit description to 72 columns.

* Added reviewed-by's from Christoph and Jan for remaining patches.

* Rebased onto 5.17-rc3.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mm: Fix invalid page pointer returned with FOLL_PIN gupsmm/gup.c+1 -10 replies
2/5mm/gup: follow_pfn_pte(): -EEXIST cleanupmm/gup.c mm/migrate.c+15 -50 replies
3/5mm/gup: remove unused pin_user_pages_locked()include/linux/mm.h mm/gup.c+0 -310 replies
4/5mm: change lookup_node() to use get_user_pages_fast()mm/mempolicy.c+9 -120 replies
5/5mm/gup: remove unused get_user_pages_locked()include/linux/mm.h mm/gup.c+0 -610 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigJan KaraDavid HildenbrandJason GunthorpeClaudio ImbrendaAlex Williamson
1/5R-b R-b R-b Debugged-by T-b
2/5R-b R-b
3/5R-b R-b R-b R-b R-b
4/5R-b R-b R-b R-b
5/5R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/5] mm/gup: some cleanups

Hi,

Here's an update, mainly just collecting reviewed-by tags:

Changes since v4:

* Patch 1: reflowed the commit description to 72 columns.

* Added reviewed-by's from Christoph and Jan for remaining patches.

* Rebased onto 5.17-rc3.

Changes since v3:

* Patch 1: Commit log: removed a reference to an out of tree module, and updated tags and added a short note to that effect.

* Patch 2: Fixed up do_move_pages(), to squash -EEXIST returns from follow_page() into something that move_pages() allows: -EFAULT. This is from reviews by Jan Kara, Matthew Wilcox, Jason Gunthorpe.

Removed all Reviewed-by tags for this patch, due to that update.

* Patch 4: Split into two patches, as recommended by Christoph Hellwig. Left the Reviewed-by tags intact because no code changes were required.

* Added Reviewed-by tags from Claudio Imbrenda.

Changes since v2:

* Patch 2: Removed an unnecessary line that was causing a clang-analyzer complaint, as reported by Lukas Bulwahn
[1] (thanks!), and retested locally.

Jason: I've boldly left your Reviewed-by tag on this patch, because I am predicting you'll agree with it...

* Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and Jason Gunthorpe that have collected since v2.

Changes since v1:
* Patch 4: changed from get_user_pages(), to get_user_pages_fast().

* Patch 4: Rewrote the commit description--thanks to Jan Kara for that feedback.

* Patch 1: Removed Jerome's Cc from patch 1, due to a stale email address.

* Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe.

Original cover letter, updated as necessary:

I'm including Peter's patch as the first one in this tiny series. (The commit description has my r-b tag in place of my Cc, and removes Jerome's Cc because he is no longer at redhat.com) The second patch is what I had in mind for a follow-up to that, when we were discussing that fix [2].

Plus, a couple more small removals that I had queued up:

The third patch removes a completely unused routine:
pin_user_pages_locked().

The forth patch removes a similar routine, get_user_pages_locked(), that only has one caller. It now calls get_user_pages_fast(), instead.

v1 of this patchset is here:
https://lore.kernel.org/all/[email protected]/

v2:
https://lore.kernel.org/r/[email protected]

v3:
https://lore.kernel.org/r/[email protected]

v4:
https://lore.kernel.org/r/[email protected]

[1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com

[2] https://lore.kernel.org/all/[email protected]/

John Hubbard (4):
mm/gup: follow_pfn_pte(): -EEXIST cleanup mm/gup: remove unused pin_user_pages_locked()
mm: change lookup_node() to use get_user_pages_fast() mm/gup: remove unused get_user_pages_locked()

Peter Xu (1):
mm: Fix invalid page pointer returned with FOLL_PIN gups

 include/linux/mm.h |   4 --
 mm/gup.c           | 101 ++++-----------------------------------------
 mm/mempolicy.c     |  21 ++++------
 mm/migrate.c       |   7 ++++
 4 files changed, 24 insertions(+), 109 deletions(-)

base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566

Signature · 1 line
2.35.1