Skip to content

hwmon: (sch56xx) Automatically load on supported hardware

Armin Wolf linux-hwmon lkml 4 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 2 repliesSuperseded
  3. v1 posting 2/24 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 posting 1/24 patches0 repliesSuperseded

Changes in v3 from the cover letter

- fix usleep_range using the same value as msleep

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4hwmon: (sch56xx) Autoload modules on platform device creationdrivers/hwmon/sch5627.c drivers/hwmon/sch5636.c+20 -00 replies
2/4hwmon: (sch56xx-common) Add automatic module loading on supported devicesdrivers/hwmon/sch56xx-common.c+38 -20 replies
3/4hwmon: (sch56xx-common) Replace msleep() with usleep_range()drivers/hwmon/sch56xx-common.c+1 -10 replies
4/4hwmon: (sch56xx-common) Replace WDOG_ACTIVE with WDOG_HW_RUNNINGdrivers/hwmon/sch56xx-common.c+1 -10 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de Goede
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] hwmon: (sch56xx) Automatically load on supported hardware

The hardware monitoring solutions supported by the sch5627 and sch5636 drivers are Fujitsu-specific.
After some online searching, i found out that the solution used with the SCH5627 is called "Antiope" by Fujitsu, just like the "Theseus" solution inside the SCH5636.
I also found out that "Antiope" and "Theseus" are listed as DMI onboard devices on supported Fujitsu devices, so the sch56xx_common module can be loaded automatically an check for the DMI devices. However some devices like the Esprimo C700 have both devices, so after verifying that at least one onboard device is present, sch56xx_common still has to detect which chip is present.
This is safe however if at least one device is present.

Tested on a Fujitsu Esprimo P720.

---
Changes in v3:
- fix usleep_range using the same value as msleep

Changes in v2:
- fix unused variable issue reported by the kernel test robot by assinging the platform device id list in sch5627/sch5636 to platform_driver->id_table.

Armin Wolf (4):
hwmon: (sch56xx) Autoload modules on platform device creation
hwmon: (sch56xx-common) Add automatic module loading on supported
devices
hwmon: (sch56xx-common) Replace msleep() with usleep_range()
hwmon: (sch56xx-common) Replace WDOG_ACTIVE with WDOG_HW_RUNNING

 drivers/hwmon/sch5627.c        | 10 ++++++++
 drivers/hwmon/sch5636.c        | 10 ++++++++
 drivers/hwmon/sch56xx-common.c | 44 ++++++++++++++++++++++++++++++----
 3 files changed, 60 insertions(+), 4 deletions(-)

--
2.30.2