Skip to content

random: use computational hash for entropy extraction, and related fixes

Jason A. Donenfeld linux-crypto lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v24 patches 8 repliesSuperseded
  3. v11 patch 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5random: use computational hash for entropy extractiondrivers/char/random.c+55 -2490 replies
2/5random: simplify entropy debitingdrivers/char/random.c include/trace/events/random.h+27 -940 replies
3/5random: use linear min-entropy accumulation creditingdrivers/char/random.c+20 -940 replies
4/5random: always wake up entropy writers after extractiondrivers/char/random.c+12 -233 replies
5/5random: make credit_entropy_bits() always safedrivers/char/random.c+9 -200 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-HartmanJean-Philippe AumassonDominik BrodowskiEric Biggers
SeriesR-b
1/5R-b R-b
2/5R-b
3/5R-b
4/5R-b R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] random: use computational hash for entropy extraction, and related fixes

The bulk of the motivation for this and description of crypto vulnerabilities is in the first patch of this series. The following three patches then fix up entropy accounting for the new model. The last patch fixes a minor code safety issue.

This v3 fixes comments and commit message wording, simplifies a bit of code in a cmpxchg loop, and adjusts semantics around the poll write wakeup threshold.

Jason A. Donenfeld (5):
random: use computational hash for entropy extraction
random: simplify entropy debiting
random: use linear min-entropy accumulation crediting
random: always wake up entropy writers after extraction
random: make credit_entropy_bits() always safe

 drivers/char/random.c         | 501 ++++++----------------------------
 include/trace/events/random.h |  30 +-
 2 files changed, 87 insertions(+), 444 deletions(-)
Signature · 1 line
2.35.0