Skip to content

add TCB driver for sama5d2

Clément Léger u-boot 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 1 replyIn review
  2. v74 patches 6 repliesSuperseded
  3. v64 patches 4 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v54 patches10 repliesSuperseded
v43 patches3 repliesSuperseded
v33 patches2 repliesSuperseded
v23 patches8 repliesSuperseded
v13 patches1 replySuperseded

Changes in v8 from the cover letter

- Switch clock to use t0_clk, generated clk does not works if parent clock is slow_ck. Moreover, tcb0_clk needs to be enabled for the TCB to operate correctly
- Change driver to use TCB_CMR_TIMER_CLOCK2 (tcb0_clk / 8)
- Add potential missing clk_enable()
- Add u-boot,dm-pre-reloc properties to TCB nodes and to its dependencies in order to be used in SPL

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5timer: atmel_tcb_timer: add atmel_tcb driverMAINTAINERS arch/arm/mach-at91/armv7/Makefile drivers/timer/Kconfig +2 more+173 -00 replies
2/5ARM: dts: at91: sama5d2: add AIC nodearch/arm/dts/sama5d2.dtsi+9 -00 replies
3/5ARM: dts: at91: sama5d2: add TCB nodearch/arm/dts/sama5d2.dtsi+16 -00 replies
4/5ARM: dts: at91: sama5d2: add u-boot, dm-pre-reloc property for TCBarch/arm/dts/sama5d2.dtsi+3 -00 replies
5/5configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMERconfigs/sama5d2_icp_mmc_defconfig configs/sama5d2_ptc_ek_mmc_defconfig configs/sama5d2_ptc_ek_nandflash_defconfig +4 more+7 -70 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchClaudiu Beznea
1/5R-b
2/5
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/5] add TCB driver for sama5d2

When booting under OP-TEE, the SYSC is secured which means the PIT is also not accessible by non-secure world. The TCB 0 however is always available for non-secure world and thus can be used.
This series add a TCB driver and enables it in sama5d2 configs.

---
Changes in v8:
- Switch clock to use t0_clk, generated clk does not works if parent clock is slow_ck. Moreover, tcb0_clk needs to be enabled for the TCB to operate correctly
- Change driver to use TCB_CMR_TIMER_CLOCK2 (tcb0_clk / 8)
- Add potential missing clk_enable()
- Add u-boot,dm-pre-reloc properties to TCB nodes and to its dependencies in order to be used in SPL

Changes in v7:
- Keep the exact same Linux aic node definition
- Fixed a few constant definition to use (1 << x)

Changes in V6:
- Fix node ordering in device tree
- Disable CONFIG_PIT_TIMER in sama5d2 configuration file
- Fixed mach-at91/armv7/Makefile to allow building with TCB

Changes in v5:
- Fixed missing include in .dts file for IRQ defines
- Add aic interrupt controller node to avoid DTC warnings

Changes in v4:
- Add missing interrupts property to tcb node

Changes in v3:
- Remove useless defines
- Add printf in case of unsupported timers specified in device-tree
- Add "syscon" compatible to tcb node

Changes in v2:
- Reworked driver to use existing Linux bindings

Clément Léger (5):
timer: atmel_tcb_timer: add atmel_tcb driver
ARM: dts: at91: sama5d2: add AIC node
ARM: dts: at91: sama5d2: add TCB node
ARM: dts: at91: sama5d2: add u-boot,dm-pre-reloc property for TCB
configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER

 MAINTAINERS                                  |   1 +
 arch/arm/dts/sama5d2.dtsi                    |  28 ++++
 arch/arm/mach-at91/armv7/Makefile            |   2 +
 configs/sama5d2_icp_mmc_defconfig            |   2 +-
 configs/sama5d2_ptc_ek_mmc_defconfig         |   2 +-
 configs/sama5d2_ptc_ek_nandflash_defconfig   |   2 +-
 configs/sama5d2_xplained_emmc_defconfig      |   2 +-
 configs/sama5d2_xplained_mmc_defconfig       |   2 +-
 configs/sama5d2_xplained_qspiflash_defconfig |   2 +-
 configs/sama5d2_xplained_spiflash_defconfig  |   2 +-
 drivers/timer/Kconfig                        |   8 +
 drivers/timer/Makefile                       |   1 +
 drivers/timer/atmel_tcb_timer.c              | 161 +++++++++++++++++++
 13 files changed, 208 insertions(+), 7 deletions(-)
 create mode 100644 drivers/timer/atmel_tcb_timer.c
Signature · 1 line
2.34.1