Skip to content

greybus: svc: fix hello processing

Johan Hovold lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3greybus: svc: fix an error handling bug in gb_svc_hello()drivers/greybus/svc.c+7 -10 replies
2/3greybus: svc: clean up hello error pathdrivers/greybus/svc.c+3 -20 replies
3/3greybus: svc: clean up link configuration hack at hellodrivers/greybus/svc.c+8 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] greybus: svc: fix hello processing

Dan found and fixed a bug in the SVC HELLO request error handling which was introduced when adding a temporary hack to reconfigure the link at HELLO.

The implementation of the hack abuses the deferred-request processing mechanism to send the link-configuration request, which makes the HELLO processing a bit hard to follow.

The last two patches attempt to remedy this.

This could go into either 5.17-rc or -next.

Johan

Dan Carpenter (1):
greybus: svc: fix an error handling bug in gb_svc_hello()

Johan Hovold (2):
greybus: svc: clean up hello error path
greybus: svc: clean up link configuration hack at hello

 drivers/greybus/svc.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1