Add arch TSC frequency information
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 1 replyIn review
- v32 patches 3 repliesSuperseded
- v21 patch 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 1 patch | 2 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf tsc: Add arch TSC frequency informationtools/ tools/ tools/ +2 more | +92 | 0 replies | |
| 2/3 | perf tsc: Add cpuinfo fall back for arch_get_tsc_freqtools/ | +48 | 0 replies | |
| 3/3 | perf test: Add test for #system_tsc_freq in metricstools/ | +13 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kan Liang |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] Add arch TSC frequency information
The first patch adds the #system_tsc_freq literal to expr.c and computes it via cpuid. The second patches adds support for "older" processors by computing the value via /proc/cpuinfo. The third patch adds a test then the computation looks somewhat sensible.
Such a literal is useful to calculate things like the average frequency [1]. The TSC frequency isn't exposed by sysfs although some experimental drivers look to add it [2].
[1] https://github.com/intel/perfmon-metrics/blob/5ad9ef7056f31075e8178b9f1fb732af183b2c8d/SKX/metrics/perf/skx_metric_perf.json#L11
[2] https://github.com/trailofbits/tsc_freq_khz
v4. Modified the patch order and separated out the test.
v3. Added the cpuid approach from Kan Liang.
v2. Adds warnings to make clear if things have changed/broken on future
Intel platforms. It also adds caching and an Intel specific that a value is computed.
Ian Rogers (2):
perf tsc: Add cpuinfo fall back for arch_get_tsc_freq perf test: Add test for #system_tsc_freq in metrics
Kan Liang (1):
perf tsc: Add arch TSC frequency information
tools/perf/arch/x86/util/cpuid.h | 34 ++++++++++++++ tools/perf/arch/x86/util/header.c | 27 +++++------ tools/perf/arch/x86/util/tsc.c | 77 +++++++++++++++++++++++++++++++ tools/perf/tests/expr.c | 13 ++++++ tools/perf/util/expr.c | 13 ++++++ tools/perf/util/tsc.h | 1 + 6 files changed, 149 insertions(+), 16 deletions(-) create mode 100644 tools/perf/arch/x86/util/cpuid.h
Signature · 1 line
2.37.0.170.g444d1eabd0-goog