Skip to content

netfilter: nat: fix soft lockup when most ports are used

Florian Westphal netfilter-devel stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2netfilter: nat: remove l4 protocol port roversinclude/net/netfilter/nf_nat_l4proto.h net/netfilter/nf_nat_proto_common.c net/netfilter/nf_nat_proto_dccp.c +3 more+8 -260 replies
2/2netfilter: nat: limit port clash resolution attemptsnet/netfilter/nf_nat_proto_common.c+23 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 4.14.y 0/2] netfilter: nat: fix soft lockup when most ports are used

First patch removes old rovers, they are inherently racy and cause packet drops/delays.

Second patch avoids iterating entire range of ports: It takes way too long when most tuples are in use.

First patch is slightly mangled; nf_nat_proto_common.c needs minor adjustment in context.

Florian Westphal (2):
netfilter: nat: remove l4 protocol port rovers
netfilter: nat: limit port clash resolution attempts

 include/net/netfilter/nf_nat_l4proto.h |  2 +-
 net/netfilter/nf_nat_proto_common.c    | 36 ++++++++++++++++++--------
 net/netfilter/nf_nat_proto_dccp.c      |  5 +---
 net/netfilter/nf_nat_proto_sctp.c      |  5 +---
 net/netfilter/nf_nat_proto_tcp.c       |  5 +---
 net/netfilter/nf_nat_proto_udp.c       | 10 ++-----
 6 files changed, 31 insertions(+), 32 deletions(-)
Signature · 1 line
2.34.1