Skip to content

mount_setattr fixes

Christian Brauner linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tests: fix idmapped mount_setattr testtools/testing/selftests/mount_setattr/mount_setattr_test.c+2 -21 reply
2/7MAINTAINERS: add entry for idmapped mountsMAINTAINERS+9 -01 reply
3/7fs: add kernel doc for mnt_{hold,unhold}_writers()fs/namespace.c+30 -01 reply
4/7fs: add mnt_allow_writers() and simplify mount_setattr_prepare()fs/namespace.c+22 -61 reply
5/7fs: simplify check in mount_setattr_commit()fs/namespace.c+2 -71 reply
6/7fs: don't open-code mnt_hold_writers()fs/namespace.c+2 -51 reply
7/7fs: clean up mount_setattr control flowfs/namespace.c+43 -411 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] mount_setattr fixes

Hey,

This contains a couple of minor fixes for the mount_setattr() code I didn't get around to sending so far. Apart from making the control flow a little easier to follow there's a fix for a long-standing braino in one of the idmapped mount kernel selftests. The kernel selftests are separate from the large fstests suite and are only concerned with testing the syscall itself whereas the fstests test all related vfs and filesystem specific functionality for idmapped mounts. I would also like to add a maintenance entry for idmapped mounts for the few files and documentation that I've written.
I'll be gone for ~10 days starting next week but I'll try to check-in regularly.

Thanks!
Christian

Christian Brauner (7):
tests: fix idmapped mount_setattr test
MAINTAINERS: add entry for idmapped mounts
fs: add kernel doc for mnt_{hold,unhold}_writers()
fs: add mnt_allow_writers() and simplify mount_setattr_prepare()
fs: simplify check in mount_setattr_commit()
fs: don't open-code mnt_hold_writers()
fs: clean up mount_setattr control flow

 MAINTAINERS                                   |   9 ++
 fs/namespace.c                                | 148 +++++++++++-------
 .../mount_setattr/mount_setattr_test.c        |   4 +-
 3 files changed, 105 insertions(+), 56 deletions(-)

base-commit: 26291c54e111ff6ba87a164d85d4a4e134b7315c

Signature · 1 line
2.32.0