Skip to content

net: ipa: use bulk interconnect interfaces

Alex Elder linux-arm-msm lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review 5 of 7 applied
  2. v17 patches 4 repliesSuperseded

Patches in v2 5 of 7 applied

#Subject and filesSizeRepliesApplied
1/7net: ipa: kill struct ipa_interconnectdrivers/net/ipa/ipa_power.c+14 -250 repliesApplied
2/7net: ipa: use icc_enable() and icc_disable()drivers/net/ipa/ipa_power.c+17 -70 repliesApplied
3/7net: ipa: use interconnect bulk enable/disable operationsdrivers/net/ipa/ipa_power.c+13 -630 replies
4/7net: ipa: use bulk operations to set up interconnectsdrivers/net/ipa/ipa_power.c+15 -250 replies
5/7net: ipa: use bulk interconnect initializationdrivers/net/ipa/ipa_power.c+23 -430 repliesApplied
6/7net: ipa: embed interconnect array in the power structuredrivers/net/ipa/ipa_power.c+9 -222 repliesApplied
7/7net: ipa: use IPA power device pointerdrivers/net/ipa/ipa_power.c+4 -40 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/7] net: ipa: use bulk interconnect interfaces

The IPA code currently enables and disables interconnects by setting the bandwidth of each to a non-zero value, or to zero. The interconnect API now supports enable/disable functions, so we can use those instead. In addition, the interconnect API provides bulk interfaces that allow all interconnects to be operated on at once.

This series converts the IPA driver to use the bulk enable and disable interfaces. In the process it uses some existing data structures rather than defining new ones.

Version 2 contains the same code as version 1; it's just rebased. Now that commit 1dba41c9d2e2d ("net: ipa: add an interconnect dependency") is in net-next/master the COMPILE_TEST build error reported for the original version should be gone.
https://lore.kernel.org/all/20220204202336.67c95e15@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/

-Alex

Alex Elder (7):
net: ipa: kill struct ipa_interconnect
net: ipa: use icc_enable() and icc_disable()
net: ipa: use interconnect bulk enable/disable operations
net: ipa: use bulk operations to set up interconnects
net: ipa: use bulk interconnect initialization
net: ipa: embed interconnect array in the power structure
net: ipa: use IPA power device pointer

 drivers/net/ipa/ipa_power.c | 178 +++++++++---------------------------
 1 file changed, 42 insertions(+), 136 deletions(-)
Signature · 1 line
2.32.0