Skip to content

block: bug fixes in preparation of AioContext removal

Emanuele Giuseppe Esposito qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 2 repliesIn review
  2. v16 patches 21 repliesSuperseded

Changes in v2 from the cover letter

* change comments in patch 2 and 3, .attach() and .detach() callbacks.
* remove job_sleep_ns patch, as it was causing random deadlocks in test 030

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drains: create bh only when pollingblock/io.c+19 -120 replies
2/10bdrv_parent_drained_begin_single: handle calls from coroutine contextblock/io.c+97 -10 replies
3/10block/io.c: fix bdrv_child_cb_drained_begin invocations from a coroutineblock.c block/io.c include/block/block-io.h+19 -110 replies
4/10block.c: bdrv_replace_child_noperm: first remove the child, and then call ->detach()block.c+14 -51 reply
5/10block.c: bdrv_replace_child_noperm: first call ->attach(), and then add childblock.c+15 -51 reply
6/10test-bdrv-drain.c: adapt test to support additional subtree drainstests/unit/test-bdrv-drain.c+11 -40 replies
7/10test-bdrv-drain.c: remove test_detach_by_parent_cb()tests/unit/test-bdrv-drain.c+11 -350 replies
8/10tests/unit/test-bdrv-drain.c: graph setup functions can't run in coroutinestests/unit/test-bdrv-drain.c+73 -450 replies
9/10child_job_drained_poll: override polling condition only when in home threadblockjob.c+10 -30 replies
10/10tests/qemu-iotests/030: test_stream_parallel should use auto_finalize=Falsetests/qemu-iotests/030+3 -90 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchStefan Hajnoczi
1/10
2/10
3/10
4/10
5/10
6/10
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] block: bug fixes in preparation of AioContext removal

This serie aims to remove and clean up some bugs that came up when trying to replace the AioContext lock and still protect BlockDriverState fields.

They were part of the serie "Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm", but since that serie is still a work in progress and these fixes are pretty much independent, I split that in two separate series.

---
v2:
* change comments in patch 2 and 3, .attach() and .detach() callbacks.
* remove job_sleep_ns patch, as it was causing random deadlocks in test 030

Emanuele Giuseppe Esposito (10):
drains: create bh only when polling bdrv_parent_drained_begin_single: handle calls from coroutine context block/io.c: fix bdrv_child_cb_drained_begin invocations from a
coroutine
block.c: bdrv_replace_child_noperm: first remove the child, and then

    call ->detach()

block.c: bdrv_replace_child_noperm: first call ->attach(), and then
add child
test-bdrv-drain.c: adapt test to the coming subtree drains test-bdrv-drain.c: remove test_detach_by_parent_cb() tests/unit/test-bdrv-drain.c: graph setup functions can't run in
coroutines
child_job_drained_poll: override polling condition only when in home
thread
tests/qemu-iotests/030: test_stream_parallel should use
auto_finalize=False

 block.c                      |  41 ++++++---
 block/io.c                   | 137 +++++++++++++++++++++++++---
 blockjob.c                   |  13 ++-
 include/block/block-io.h     |  20 +++--
 tests/qemu-iotests/030       |  12 +--
 tests/unit/test-bdrv-drain.c | 169 +++++++++++++++++++----------------
 6 files changed, 267 insertions(+), 125 deletions(-)
Signature · 1 line
2.31.1