Skip to content

irqchip: Prevent drivers abusing irq_chip::name

Marc Zyngier linux-gpio lkml 1 version Applied

Status from this message: The following commit has been merged into the irq/irqchip-next branch of irqchip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 21 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/10irqdomain: Let irq_domain_set_{info,hwirq_and_chip} take a const irq_chipinclude/linux/irqdomain.h kernel/irq/irqdomain.c+7 -50 replies
2/10genirq: Allow irq_chip registration functions to take a const irq_chipinclude/linux/irq.h kernel/irq/chip.c+7 -90 replies
3/10irqchip/gic: Switch to dynamic chip name outputdrivers/irqchip/irq-gic.c+54 -482 replies
4/10irqchip/lpc32xx: Switch to dynamic chip name outputdrivers/irqchip/irq-lpc32xx.c+22 -120 replies
5/10irqchip/mvebu-pic: Switch to dynamic chip name outputdrivers/irqchip/irq-mvebu-pic.c+18 -101 reply
6/10irqchip/ts4800: Switch to dynamic chip name outputdrivers/irqchip/irq-ts4800.c+17 -80 replies
7/10irqchip/versatile-fpga: Switch to dynamic chip name outputdrivers/irqchip/irq-ftintc010.c drivers/irqchip/irq-versatile-fpga.c include/linux/irqchip/versatile-fpga.h+26 -351 reply
8/10gpio: mt7621: Switch to dynamic chip name outputdrivers/gpio/gpio-mt7621.c+11 -10 replies
9/10gpio: omap: Switch to dynamic chip name outputdrivers/gpio/gpio-omap.c+18 -100 replies
10/10pinctrl: starfive: Switch to dynamic chip name outputdrivers/pinctrl/pinctrl-starfive.c+9 -213 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEmil Renner BerthingLinus WalleijGregory CLEMENT
SeriesA-b
1/10
2/10
3/10R-b
4/10
5/10R-b
6/10
7/10R-b
8/10
9/10
10/10R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] irqchip: Prevent drivers abusing irq_chip::name

Another common abuse in irqchip drivers (and derivatives) is to place a string representing the underlying device in the irq_chip::name field that gets displayed in /proc/interrupts while this should only be an indication of the "type" of interrupt controller.

Not only this is pretty pointless (with hierarchical domains, you only see the top chip), but it also gets in the way of making the irq_chip structure const. For debug, we have a whole infrastructure that does everything you can imagine (and stuff you don't want to).

We can't remove this name as it is visible from userspace and there is a whole collection of CI scripts that parse /proc/interrupts for good (and mostly bad) reasons. The solution is to use the irq_print_chip() callback and to let it output whatever string is necessary.

Having done that, we can cleanup a few irqchip drivers and make their irq_chip structure const (which requires touching a handful of core functions). Whilst we're at it, we do the same for a couple of gpio drivers.

This series relies on the one posted at [1].

Thanks,

	M.

[1] https://lore.kernel.org/r/[email protected]

Marc Zyngier (10):
irqdomain: Let irq_domain_set_{info,hwirq_and_chip} take a const
irq_chip
genirq: Allow irq_chip registration functions to take a const irq_chip irqchip/gic: Switch to dynamic chip name output irqchip/lpc32xx: Switch to dynamic chip name output irqchip/mvebu-pic: Switch to dynamic chip name output irqchip/ts4800: Switch to dynamic chip name output irqchip/versatile-fpga: Switch to dynamic chip name output
gpio: mt7621: Switch to dynamic chip name output
gpio: omap: Switch to dynamic chip name output
pinctrl: starfive: Switch to dynamic chip name output

 drivers/gpio/gpio-mt7621.c             |  12 ++-
 drivers/gpio/gpio-omap.c               |  28 ++++---
 drivers/irqchip/irq-ftintc010.c        |   1 -
 drivers/irqchip/irq-gic.c              | 102 +++++++++++++------------
 drivers/irqchip/irq-lpc32xx.c          |  34 ++++++---
 drivers/irqchip/irq-mvebu-pic.c        |  28 ++++---
 drivers/irqchip/irq-ts4800.c           |  25 ++++--
 drivers/irqchip/irq-versatile-fpga.c   |  46 ++++++-----
 drivers/pinctrl/pinctrl-starfive.c     |  11 ++-
 include/linux/irq.h                    |   7 +-
 include/linux/irqchip/versatile-fpga.h |  14 ----
 include/linux/irqdomain.h              |   5 +-
 kernel/irq/chip.c                      |   9 +--
 kernel/irq/irqdomain.c                 |   7 +-
 14 files changed, 189 insertions(+), 140 deletions(-)
 delete mode 100644 include/linux/irqchip/versatile-fpga.h
Signature · 1 line
2.30.2