Skip to content

memcg: robust enforcement of memory.high

Shakeel Butt cgroups linux-mm lkml 2 versions – Applied

Status from this message: [merged] selftests-memcg-test-high-limit-for-single-entry-allocation.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesApplied 4/4
  2. v14 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Based on Roman's comment simply the sync enforcement and only target the extreme cases.

Patches in v2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4memcg: refactor mem_cgroup_oommm/memcontrol.c+17 -270 repliesApplied
2/4memcg: unify force charging conditionsmm/memcontrol.c+7 -100 repliesApplied
3/4selftests: memcg: test high limit for single entry allocationtools/testing/selftests/cgroup/cgroup_util.c tools/testing/selftests/cgroup/cgroup_util.h tools/testing/selftests/cgroup/test_memcontrol.c+91 -31 replyApplied
4/4memcg: synchronously enforce memory.high for large overchargesmm/memcontrol.c+5 -05 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRoman GushchinChris Down
1/4R-b
2/4R-b
3/4R-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] memcg: robust enforcement of memory.high

Due to the semantics of memory.high enforcement i.e. throttle the workload without oom-kill, we are trying to use it for right sizing the workloads in our production environment. However we observed the mechanism fails for some specific applications which does big chunck of allocations in a single syscall. The reason behind this failure is due to the limitation of the memory.high enforcement's current implementation. This patch series solves this issue by enforcing the memory.high synchronously if the current process has accumulated a large amount of high overcharge.

Changes since v1:
- Based on Roman's comment simply the sync enforcement and only target the extreme cases.

Shakeel Butt (4):
memcg: refactor mem_cgroup_oom
memcg: unify force charging conditions
selftests: memcg: test high limit for single entry allocation
memcg: synchronously enforce memory.high for large overcharges

 mm/memcontrol.c                               | 66 +++++++---------
 tools/testing/selftests/cgroup/cgroup_util.c  | 15 +++-
 tools/testing/selftests/cgroup/cgroup_util.h  |  1 +
 .../selftests/cgroup/test_memcontrol.c        | 78 +++++++++++++++++++
 4 files changed, 120 insertions(+), 40 deletions(-)
Signature · 1 line
2.35.1.265.g69c8d7142f-goog