Skip to content

make statx() return DIO alignment information

Eric Biggers linux-api linux-block linux-ext4 linux-f2fs-devel linux-fscrypt linux-fsdevel linux-next linux-xfs lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 14 repliesIn review
  2. v49 patches 22 repliesSuperseded
  3. v38 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC7 patches13 repliesSuperseded
v1 RFC7 patches2 repliesSuperseded

Changes in v5 from the cover letter

- Accounted for the DIO changes in 6.0 by setting dio_mem_align to the DMA alignment instead of the logical block size where needed.

- Dropped the patch "f2fs: don't allow DIO reads but not DIO writes".

- Added some Reviewed-by and Acked-by tags.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8statx: add direct I/O alignment informationfs/stat.c include/linux/stat.h include/uapi/linux/stat.h+7 -11 reply
2/8vfs: support STATX_DIOALIGN on block devicesblock/bdev.c fs/stat.c include/linux/blkdev.h+39 -02 replies
3/8fscrypt: change fscrypt_dio_supported() to prepare for STATX_DIOALIGNfs/crypto/inline_crypt.c fs/ext4/file.c fs/f2fs/f2fs.h +1 more+34 -330 replies
4/8ext4: support STATX_DIOALIGNfs/ext4/ext4.h fs/ext4/file.c fs/ext4/inode.c+64 -160 replies
5/8f2fs: move f2fs_force_buffered_io() into file.cfs/f2fs/f2fs.h fs/f2fs/file.c+40 -401 reply
6/8f2fs: simplify f2fs_force_buffered_io()fs/f2fs/file.c+5 -221 reply
7/8f2fs: support STATX_DIOALIGNfs/f2fs/file.c+18 -01 reply
8/8xfs: support STATX_DIOALIGNfs/xfs/xfs_iops.c+10 -02 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. WongMartin K. PetersenTheodore Ts'oJaegeuk KimChristian Brauner (Microsoft)
1/8R-b R-b R-b R-b
2/8R-b R-b
3/8R-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/8] make statx() return DIO alignment information

This patchset makes the statx() system call return direct I/O (DIO) alignment information. This allows userspace to easily determine whether a file supports DIO, and if so with what alignment restrictions.

Patch 1 adds the basic VFS support for STATX_DIOALIGN. Patch 2 wires it up for all block device files. The remaining patches wire it up for regular files on ext4, f2fs, and xfs. Support for regular files on other filesystems can be added later.

I've also written a man-pages patch, which I sent separately:
https://lore.kernel.org/r/[email protected]

Note, f2fs has a corner case where DIO reads are allowed but not DIO writes. The proposed statx fields can't represent this. The current proposal just reports that DIO is unsupported in this case.

This patchset applies to v6.0-rc2.

Changed in v5:
- Accounted for the DIO changes in 6.0 by setting dio_mem_align to the DMA alignment instead of the logical block size where needed.

- Dropped the patch "f2fs: don't allow DIO reads but not DIO writes".

- Added some Reviewed-by and Acked-by tags.

Changed in v4:
- Added xfs support.

- Moved the helper function for block devices into block/bdev.c.

- Adjusted the ext4 patch to not introduce a bug where misaligned DIO starts being allowed on encrypted files when it gets combined with the patch "iomap: add support for dma aligned direct-io" that is queued in the block tree for 5.20.

- Made a simplification in fscrypt_dio_supported().

Changed in v3:
- Dropped the stx_offset_align_optimal field, since its purpose wasn't clearly distinguished from the existing stx_blksize.

- Renamed STATX_IOALIGN to STATX_DIOALIGN, to reflect the new focus on DIO only.

- Similarly, renamed stx_{mem,offset}_align_dio to stx_dio_{mem,offset}_align, to reflect the new focus on DIO only.

- Wired up STATX_DIOALIGN on block device files.

Changed in v2:
- No changes.

Eric Biggers (8):
statx: add direct I/O alignment information
vfs: support STATX_DIOALIGN on block devices
fscrypt: change fscrypt_dio_supported() to prepare for STATX_DIOALIGN
ext4: support STATX_DIOALIGN
f2fs: move f2fs_force_buffered_io() into file.c
f2fs: simplify f2fs_force_buffered_io()
f2fs: support STATX_DIOALIGN
xfs: support STATX_DIOALIGN

 block/bdev.c              | 23 ++++++++++++++++++
 fs/crypto/inline_crypt.c  | 49 +++++++++++++++++++--------------------
 fs/ext4/ext4.h            |  1 +
 fs/ext4/file.c            | 37 ++++++++++++++++++++---------
 fs/ext4/inode.c           | 37 +++++++++++++++++++++++++++++
 fs/f2fs/f2fs.h            | 40 --------------------------------
 fs/f2fs/file.c            | 43 +++++++++++++++++++++++++++++++++-
 fs/stat.c                 | 14 +++++++++++
 fs/xfs/xfs_iops.c         | 10 ++++++++
 include/linux/blkdev.h    |  4 ++++
 include/linux/fscrypt.h   |  7 ++----
 include/linux/stat.h      |  2 ++
 include/uapi/linux/stat.h |  4 +++-
 13 files changed, 188 insertions(+), 83 deletions(-)

base-commit: 1c23f9e627a7b412978b4e852793c5e3c3efc555

Signature · 1 line
2.37.2