Skip to content

hw/nvme: enhanced protection information (64-bit guard)

Klaus Jensen qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesIn review
  2. v16 patches 2 repliesSuperseded

Changes in v2 from the cover letter

~~~~~~~~~~~~~~~~
- Check metadata size depending on pi guard type selected. (Keith)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/nvme: move dif/pi prototypes into dif.hhw/nvme/ctrl.c hw/nvme/dif.c hw/nvme/dif.h +1 more+55 -500 replies
2/6hw/nvme: add host behavior support featurehw/nvme/ctrl.c hw/nvme/nvme.h include/block/nvme.h+20 -10 replies
3/6hw/nvme: move format parameter parsinghw/nvme/ctrl.c+18 -130 replies
4/6hw/nvme: add support for the lbafee hbs featurehw/nvme/ctrl.c hw/nvme/ns.c hw/nvme/nvme.h +1 more+46 -110 replies
5/6hw/nvme: add pi tuple size helperhw/nvme/ctrl.c hw/nvme/dif.c hw/nvme/dif.h+21 -140 replies
6/6hw/nvme: 64-bit pi supporthw/nvme/ctrl.c hw/nvme/dif.c hw/nvme/dif.h +4 more+648 -1380 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKeith Busch
SeriesR-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] hw/nvme: enhanced protection information (64-bit guard)

From: Klaus Jensen <[email protected]>

This adds support for one possible new protection information format introduced in TP4068 (and integrated in NVMe 2.0): the 64-bit CRC guard and 48-bit reference tag. This version does not support storage tags.

Like the CRC16 support already present, this uses a software implementation of CRC64 (so it is naturally pretty slow). But its good enough for verification purposes.

This goes hand-in-hand with the support that Keith submitted for the Linux kernel[1].

[1]: https://lore.kernel.org/linux-nvme/[email protected]/

Changes since v1
~~~~~~~~~~~~~~~~
- Check metadata size depending on pi guard type selected. (Keith)

Klaus Jensen (3):
hw/nvme: move dif/pi prototypes into dif.h
hw/nvme: move format parameter parsing
hw/nvme: add pi tuple size helper

Naveen Nagar (3):
hw/nvme: add host behavior support feature
hw/nvme: add support for the lbafee hbs feature
hw/nvme: 64-bit pi support

 hw/nvme/ctrl.c       | 235 +++++++++++++++++++++------
 hw/nvme/dif.c        | 378 +++++++++++++++++++++++++++++++++----------
 hw/nvme/dif.h        | 191 ++++++++++++++++++++++
 hw/nvme/ns.c         |  50 ++++--
 hw/nvme/nvme.h       |  58 +------
 hw/nvme/trace-events |  12 +-
 include/block/nvme.h |  81 ++++++++--
 7 files changed, 793 insertions(+), 212 deletions(-)
 create mode 100644 hw/nvme/dif.h
Signature · 1 line
2.35.1