Skip to content

mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N

Tokunori Ikegami linux-mtd stable 6 versions – Applied

Status from this message: Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 10 repliesApplied
  2. v53 patches 2 repliesSuperseded
  3. v43 patches 19 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches6 repliesSuperseded
v21 patch5 repliesSuperseded
v11 patch4 repliesSuperseded

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/4mtd: cfi_cmdset_0002: Move and rename chip_check/chip_ready/chip_good_for_writedrivers/mtd/chips/cfi_cmdset_0002.c+32 -631 reply
2/4mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064Ndrivers/mtd/chips/cfi_cmdset_0002.c include/linux/mtd/cfi.h+35 -81 reply
3/4mtd: cfi_cmdset_0002: Add S29GL064N ID definitiondrivers/mtd/chips/cfi_cmdset_0002.c+3 -21 reply
4/4mtd: cfi_cmdset_0002: Rename chip_ready variablesdrivers/mtd/chips/cfi_cmdset_0002.c+7 -71 reply

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAhmad FatoumVignesh Raghavendra
SeriesT-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N

Since commit dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value") buffered writes fail on S29GL064N. This is because, on S29GL064N, reads return 0xFF at the end of DQ polling for write completion, where as, chip_good() check expects actual data written to the last location to be returned post DQ polling completion. Fix is to revert to using chip_good() for S29GL064N which only checks for DQ lines to settle down to determine write completion.

Fixes dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value")

Tokunori Ikegami (4):
mtd: cfi_cmdset_0002: Move and rename
chip_check/chip_ready/chip_good_for_write
mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N
mtd: cfi_cmdset_0002: Add S29GL064N ID definition
mtd: cfi_cmdset_0002: Rename chip_ready variables

 drivers/mtd/chips/cfi_cmdset_0002.c | 112 ++++++++++++++--------------
 include/linux/mtd/cfi.h             |   1 +
 2 files changed, 55 insertions(+), 58 deletions(-)
Signature · 1 line
2.32.0