Skip to content

hwmon: (dell-smm) Miscellaneous improvements

Armin Wolf linux-hwmon lkml llvm oe-kbuild-all 1 version Applied

Status from this message: Applied to hwmon-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7hwmon: (dell-smm) Allow for specifying fan control method as module parameterDocumentation/admin-guide/kernel-parameters.txt Documentation/hwmon/dell-smm-hwmon.rst drivers/hwmon/dell-smm-hwmon.c+35 -146 replies
2/7hwmon: (dell-smm) Add additional fan mode command combinationDocumentation/hwmon/dell-smm-hwmon.rst drivers/hwmon/dell-smm-hwmon.c+9 -30 replies
3/7hwmon: (dell-smm) Make fan/temp sensor number a u8drivers/hwmon/dell-smm-hwmon.c+45 -232 replies
4/7hwmon: (dell-smm) Improve temperature sensors detectiondrivers/hwmon/dell-smm-hwmon.c+5 -01 reply
5/7hwmon: (dell-smm) Improve assembly codedrivers/hwmon/dell-smm-hwmon.c+17 -540 replies
6/7hwmon: (dell-smm) Add SMM interface documentationDocumentation/hwmon/dell-smm-hwmon.rst+180 -02 replies
7/7hwmon: (dell-smm) Reword and mark parameter "force" as unsafedrivers/hwmon/dell-smm-hwmon.c+2 -22 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchPali Rohár
1/7
2/7
3/7R-b
4/7
5/7
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] hwmon: (dell-smm) Miscellaneous improvements

This patch set contains miscellaneous improvements for the dell_smm_hwmon driver.
The first two patches allow for testing known SMM code pairs for automatic fan mode enable/disable without having to manually edit and recompile the module, which makes testing easier and is compatible with Secure Boot/Kernel Lockdown. Because of the later, users cannot specify arbitrary SMM codes, but are limited to two promising code pairs (for now). The fifth patch improves the inline assembly code, so saving/restoring the registers is done by the compiler, including the flags register. As a side effect, it now works on both 32 and 64 bit x86, while being faster too. The remaining patches are smaller improvments.

All patches have been tested on a Dell Inspiron 3505.

Armin Wolf (7):
hwmon: (dell-smm) Allow for specifying fan control method as module
parameter
hwmon: (dell-smm) Add additional fan mode command combination
hwmon: (dell-smm) Make fan/temp sensor number a u8
hwmon: (dell-smm) Improve temperature sensors detection
hwmon: (dell-smm) Improve assembly code
hwmon: (dell-smm) Add SMM interface documentation
hwmon: (dell-smm) Reword and mark parameter "force" as unsafe

 .../admin-guide/kernel-parameters.txt         |   3 +
 Documentation/hwmon/dell-smm-hwmon.rst        | 202 +++++++++++++++++-
 drivers/hwmon/dell-smm-hwmon.c                | 178 +++++++--------
 3 files changed, 290 insertions(+), 93 deletions(-)

--
2.30.2