Skip to content

Avoid process exit return values in igt_kmod

Anshuman Gupta igt-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

- Addressed review comment from Ashutosh.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/igt_kmod: Don't use process exit return valuelib/igt_kmod.c+21 -130 replies
2/2test/perf_pmu: Change module unload assertiontests/i915/perf_pmu.c+6 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAshutosh Dixit
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [igt-dev] [PATCH i-g-t v3 0/2] Avoid process exit return values in igt_kmod

Kmod igt library functions like igt_i915_driver_{load, unload} uses process exit IGT_EXIT_{FAILURE, SKIP, SUCCESS} return values. Let these function return actual return values
from returned igt_kmod_{load, unload} functions.

Also modify the perf_pmu test to use
__igt_i915_driver_unload() accordingly.

v2:
- Addressed review comment from petri.
v3:
- Addressed review comment from Ashutosh.

Anshuman Gupta (2):
lib/igt_kmod: Don't use process exit return value test/perf_pmu: Change module unload assertion

 lib/igt_kmod.c        | 34 +++++++++++++++++++++-------------
 tests/i915/perf_pmu.c | 10 ++++++----
 2 files changed, 27 insertions(+), 17 deletions(-)
Signature · 1 line
2.26.2