Skip to content

Prep work for next GuC release

[email protected] dri-devel intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v28 patches 6 repliesSuperseded
  3. v18 patches 11 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/guc: Do not conflate lrc_desc with GuC id for registrationdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+38 -310 replies
2/8drm/i915/guc: Add an explicit 'submission_initialized' flagdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+7 -30 replies
3/8drm/i915/guc: Better name for context id limitdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+12 -120 replies
4/8drm/i915/guc: Split guc_lrc_desc_pin apartdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+33 -210 replies
5/8drm/i915/guc: Move lrc desc setup to where it is neededdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+4 -20 replies
6/8drm/i915/guc: Rename desc_idx to ctx_iddrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+26 -260 replies
7/8drm/i915/guc: Drop obsolete H2G definitionsdrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h+0 -20 replies
8/8drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hsdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+4 -20 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo Spurio
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] Prep work for next GuC release

From: John Harrison <[email protected]>

The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really have been used for anyway.

v2: Extend commit message on 'better name' patch. Improve 'split apart' patch to include some necessary re-arrangement that was in a later patch and which introduced an unnecessary conditional in said patch too. (review feedback from Daniele)

v3: Rebase to newer tree.

John Harrison (8):
drm/i915/guc: Do not conflate lrc_desc with GuC id for registration drm/i915/guc: Add an explicit 'submission_initialized' flag drm/i915/guc: Better name for context id limit drm/i915/guc: Split guc_lrc_desc_pin apart
drm/i915/guc: Move lrc desc setup to where it is needed drm/i915/guc: Rename desc_idx to ctx_id
drm/i915/guc: Drop obsolete H2G definitions
drm/i915/guc: Fix potential invalid pointer dereferences when decoding
G2Hs

 drivers/gpu/drm/i915/gt/intel_context.c       |   2 +-
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   2 -
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |   4 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 181 ++++++++++--------
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     |   2 +-
 6 files changed, 109 insertions(+), 84 deletions(-)
Signature · 1 line
2.25.1