Skip to content

Enable PCIe ASPM and LTR on select hardware

David E. Box intel-gfx linux-pci lkml 8 versions – Applied

Status from this message: Applied to pci/controller/vmd, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest4 patches 6 repliesApplied
  2. v94 patches 3 repliesSuperseded
  3. v8 posting 2/24 patches 5 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v8 posting 1/24 patches5 repliesSuperseded
v7 posting 2/24 patches8 repliesSuperseded
v7 posting 1/20 of 4 patches0 repliesSuperseded
v63 patches9 repliesSuperseded
v53 patches4 repliesSuperseded

Patches in v10 Applied

#Subject and filesSizeRepliesApplied
1/4PCI/ASPM: Add pci_enable_link_state()drivers/pci/pcie/aspm.c include/linux/pci.h+61 -00 replies
2/4PCI: vmd: Use PCI_VDEVICE in device listdrivers/pci/controller/vmd.c+8 -80 replies
3/4PCI: vmd: Create feature grouping for client productsdrivers/pci/controller/vmd.c+10 -180 replies
4/4PCI: vmd: Add quirk to configure PCIe ASPM and LTRdrivers/pci/controller/vmd.c+54 -14 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBjorn HelgaasJon DerrickNirmal PatelKuppuswamy Sathyanarayanan
SeriesR-b
1/4A-b
2/4R-b R-b
3/4
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH V10 0/4] Enable PCIe ASPM and LTR on select hardware

This series adds a work around for enabling PCIe ASPM and for setting PCIe LTR values on VMD reserved root ports on select platforms. While configuration of these capabilities is usually done by BIOS, on these platforms these capabilities will not be configured because the ports are not visible to BIOS. This was part of an initial design that expected the driver to completely handle the ports, including power management. However on Linux those ports are still managed by the PCIe core, which has the expectation that they adhere to device standards including BIOS configuration, leading to this problem.

The target platforms are Tiger Lake, Alder Lake, and Raptor Lake though the latter has already implemented support for configuring the LTR values. Meteor Lake is expected add BIOS ASPM support, eliminating the future need for this work around.

Note, the driver programs the LTRs because BIOS would also normally do this for devices that do not set them by default. Without this, SoC power management would be blocked on those platform. This SoC specific value is the maximum latency required to allow the SoC to enter the deepest power state.

This patch addresses the following open bugzillas on VMD enabled laptops that cannot enter low power states.

David E. Box (3):
PCI: vmd: Use PCI_VDEVICE in device list
PCI: vmd: Create feature grouping for client products
PCI: vmd: Add quirk to configure PCIe ASPM and LTR

Michael Bottini (1):
PCI/ASPM: Add pci_enable_link_state()

 drivers/pci/controller/vmd.c | 97 ++++++++++++++++++++++++++----------
 drivers/pci/pcie/aspm.c      | 54 ++++++++++++++++++++
 include/linux/pci.h          |  7 +++
 3 files changed, 132 insertions(+), 26 deletions(-)

base-commit: 5dc4c995db9eb45f6373a956eb1f69460e69e6d4

Signature · 1 line
2.34.1