Skip to content

Improve anti-pre-emption w/a for compute workloads

[email protected] dri-devel intel-gfx 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 5 repliesIn review
  2. v44 patches 10 repliesSuperseded
  3. v34 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches3 repliesSuperseded
v13 patches50 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/guc: Limit scheduling properties to avoid overflowdrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/sysfs_engines.c +2 more+119 -101 reply
2/4drm/i915: Fix compute pre-emption w/a to apply to compute enginesdrivers/gpu/drm/i915/gt/intel_engine_cs.c+12 -120 replies
3/4drm/i915: Make the heartbeat play nice with long pre-emption timeoutsdrivers/gpu/drm/i915/gt/intel_engine_heartbeat.c+39 -01 reply
4/4drm/i915: Improve long running compute w/a for GuC submissiondrivers/gpu/drm/i915/Kconfig.profile drivers/gpu/drm/i915/gt/intel_engine_cs.c+29 -61 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo SpurioTvrtko UrsulinMatt RoperMichal Mrozek
1/4R-b A-b
2/4R-b
3/4R-b
4/4R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/4] Improve anti-pre-emption w/a for compute workloads

From: John Harrison <[email protected]>

Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang detection was left to the heartbeat and its (longer) timeout. This is undesirable with GuC submission as the heartbeat is a full GT reset rather than a per engine reset and so is much more destructive. Instead, just bump the pre-emption timeout to a big value. Also, update the heartbeat to allow such a long pre-emption delay in the final heartbeat period.

v2: Add clamping helpers.
v3: Remove long timeout algorithm and replace with hard coded value (review feedback from Tvrtko). Also, fix execlist selftest failure and fix bug in compute enabling patch related to pre-emption timeouts.
v4: Add multiple BUG_ONs to re-check already range checked values (Tvrtko)
v5: Add FIXMEs and drm_notices about setting non-default heartbeat periods (Tvrtko)

John Harrison (4):
drm/i915/guc: Limit scheduling properties to avoid overflow drm/i915: Fix compute pre-emption w/a to apply to compute engines drm/i915: Make the heartbeat play nice with long pre-emption timeouts drm/i915: Improve long running compute w/a for GuC submission

 drivers/gpu/drm/i915/Kconfig.profile          |  26 ++++-
 drivers/gpu/drm/i915/gt/intel_engine.h        |   6 ++
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     | 102 +++++++++++++++---
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |  39 +++++++
 drivers/gpu/drm/i915/gt/sysfs_engines.c       |  25 +++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |  21 ++++
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |   8 ++
 7 files changed, 199 insertions(+), 28 deletions(-)
Signature · 1 line
2.37.3