Improve anti-pre-emption w/a for compute workloads
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest4 patches 5 repliesIn review
- v44 patches 10 repliesSuperseded
- v34 patches 10 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 3 replies | Superseded | |
| v1 | 3 patches | 50 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm/i915/guc: Limit scheduling properties to avoid overflowdrivers/ drivers/ drivers/ +2 more | +119 | 1 reply | |
| 2/4 | drm/i915: Fix compute pre-emption w/a to apply to compute enginesdrivers/ | +12 | 0 replies | |
| 3/4 | drm/i915: Make the heartbeat play nice with long pre-emption timeoutsdrivers/ | +39 | 1 reply | |
| 4/4 | drm/i915: Improve long running compute w/a for GuC submissiondrivers/ drivers/ | +29 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Daniele Ceraolo Spurio | Tvrtko Ursulin | Matt Roper | Michal Mrozek |
|---|---|---|---|---|
| 1/4 | R-b | A-b | ||
| 2/4 | R-b | |||
| 3/4 | R-b | |||
| 4/4 | R-b | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 0/4] Improve anti-pre-emption w/a for compute workloads
From: John Harrison <[email protected]>
Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang detection was left to the heartbeat and its (longer) timeout. This is undesirable with GuC submission as the heartbeat is a full GT reset rather than a per engine reset and so is much more destructive. Instead, just bump the pre-emption timeout to a big value. Also, update the heartbeat to allow such a long pre-emption delay in the final heartbeat period.
v2: Add clamping helpers.
v3: Remove long timeout algorithm and replace with hard coded value (review feedback from Tvrtko). Also, fix execlist selftest failure and fix bug in compute enabling patch related to pre-emption timeouts.
v4: Add multiple BUG_ONs to re-check already range checked values (Tvrtko)
v5: Add FIXMEs and drm_notices about setting non-default heartbeat periods (Tvrtko)
John Harrison (4):
drm/i915/guc: Limit scheduling properties to avoid overflow drm/i915: Fix compute pre-emption w/a to apply to compute engines drm/i915: Make the heartbeat play nice with long pre-emption timeouts drm/i915: Improve long running compute w/a for GuC submission
drivers/gpu/drm/i915/Kconfig.profile | 26 ++++- drivers/gpu/drm/i915/gt/intel_engine.h | 6 ++ drivers/gpu/drm/i915/gt/intel_engine_cs.c | 102 +++++++++++++++--- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 39 +++++++ drivers/gpu/drm/i915/gt/sysfs_engines.c | 25 +++-- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 21 ++++ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 8 ++ 7 files changed, 199 insertions(+), 28 deletions(-)
Signature · 1 line
2.37.3