Skip to content

Fix DHCP renew handling

Lars Steubesand connman 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/23 patches 0 repliesNew
  2. v1 posting 1/23 patches 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gdhcp: Set packet length when receiving L3 packetgdhcp/client.c+1 -00 replies
2/3gdhcp: Further check invalid data in dhcp_get_optiongdhcp/common.c+46 -70 replies
3/3gdhcp: Add unit tests for dhcp_get_option.gitignore Makefile.am gdhcp/client.c +4 more+402 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH resend 0/3] Fix DHCP renew handling

From: Lars Steubesand <[email protected]>

It appears that commit
58d397ba7487 ("gdhcp: Avoid reading invalid data in dhcp_get_option") broke DHCP renew handling. Fix this and add more robust handling of DHCP options with length checks.

The patch
[PATCH 3/3] gdhcp: Add unit tests for dhcp_get_option some minimal form of unit testing for parsing DHCP options. If not required or not desired this way the patch can be dropped.

Lars Steubesand (2):
gdhcp: Further check invalid data in dhcp_get_option
gdhcp: Add unit tests for dhcp_get_option

Lauser, Simon (1):
gdhcp: Set packet length when receiving L3 packet

 .gitignore               |   1 +
 Makefile.am              |   9 +
 gdhcp/client.c           |  11 +-
 gdhcp/common.c           |  73 +++++++-
 gdhcp/common.h           |   2 +-
 gdhcp/server.c           |   6 +-
 unit/test-dhcp-options.c | 365 +++++++++++++++++++++++++++++++++++++++
 7 files changed, 449 insertions(+), 18 deletions(-)
 create mode 100644 unit/test-dhcp-options.c

base-commit: 4c25afef72b40c71e8f9d242e6677fee0aa020a4

Signature · 1 line
2.35.1