Skip to content

net/mlx5: fix link state detection

Dmitry Kozlyuk dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v13 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3common/mlx5: add Netlink event helpersdrivers/common/mlx5/linux/mlx5_common_os.c drivers/common/mlx5/linux/mlx5_nl.c drivers/common/mlx5/linux/mlx5_nl.h +3 more+116 -84 replies
2/3net/mlx5: fix link status change detectiondrivers/net/mlx5/linux/mlx5_ethdev_os.c drivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c +2 more+120 -140 replies
3/3net/mlx5: fix initial link status detectiondrivers/net/mlx5/linux/mlx5_os.c+5 -60 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchViacheslav Ovsiienko
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] net/mlx5: fix link state detection

This patchset fixes two related issues:
* In rare occasions with any HW link state change to UP was missed.
* If a port was DOWN before startup, its netdev would come UP, but appear DOWN in DPDK (especially probable with ConnectX-4).

v2: fix not detecting the link up when it was up before the app start.

Dmitry Kozlyuk (3):
common/mlx5: add Netlink event helpers
net/mlx5: fix link status change detection
net/mlx5: fix initial link status detection

 drivers/common/mlx5/linux/mlx5_common_os.c |   2 +-
 drivers/common/mlx5/linux/mlx5_nl.c        | 102 ++++++++++++++++++++-
 drivers/common/mlx5/linux/mlx5_nl.h        |   8 +-
 drivers/common/mlx5/version.map            |   2 +
 drivers/net/mlx5/linux/mlx5_ethdev_os.c    |  63 ++++++++++---
 drivers/net/mlx5/linux/mlx5_os.c           |  74 +++++++++++++--
 drivers/net/mlx5/linux/mlx5_vlan_os.c      |   2 +-
 drivers/net/mlx5/mlx5.c                    |   1 +
 drivers/net/mlx5/mlx5.h                    |   3 +
 drivers/net/mlx5/mlx5_trigger.c            |  12 ++-
 10 files changed, 241 insertions(+), 28 deletions(-)
Signature · 1 line
2.25.1