Skip to content

Fix broken PCIe device after migration

Igor Mammedov qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v14 patches 24 repliesSuperseded

Changes in v2 from the cover letter

* instead of disabling power control on slot and letting ACPI PCI hotplug module in guest to deal with it, set PCI_EXP_SLTCTL_PWR_ON on PCIe slot from acpi_pcihp_device_plug_cb() when a device plugged into it.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pci: expose TYPE_XIO3130_DOWNSTREAM namehw/pci-bridge/xio3130_downstream.c include/hw/pci-bridge/xio3130_downstream.h+17 -10 replies
2/3acpi: pcihp: pcie: set power on cap on parent slothw/acpi/pcihp.c hw/pci/pcie.c include/hw/pci/pcie.h+23 -10 replies
3/3q35: compat: keep hotplugged PCIe device broken after migration for 6.2 and older machine typeshw/acpi/ich9.c hw/acpi/pcihp.c hw/core/machine.c +1 more+31 -52 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fix broken PCIe device after migration

Changelog:
v2:
* instead of disabling power control on slot and letting ACPI PCI hotplug module in guest to deal with it, set PCI_EXP_SLTCTL_PWR_ON on PCIe slot from acpi_pcihp_device_plug_cb() when a device plugged into it.

Currently ACPI PCI hotplug is enabled by default for Q35 machine type and overrides native PCIe hotplug. It works as expected when a PCIe device is hotplugged into slot, however the device becomes in-operational after migration. Which is caused by BARs being disabled on target due to powered off status of the slot.

Proposed fix turns on power on PCIe slot when a device is hotplugged into it, then that state is migrated and device stays powred on after migration.

Tested with (seabios: FC34, Win2012; ovmf: RHEL8)

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2053584
CC: [email protected]
CC: [email protected]

Ref to v1:
https://lore.kernel.org/all/[email protected]/T/
Gitlab link:
https://gitlab.com/imammedo/qemu/-/tree/pcie_poweroff_acpi_regression_rhbz2053584_V2

Igor Mammedov (3):
pci: expose TYPE_XIO3130_DOWNSTREAM name
acpi: pcihp: pcie: set power on cap on parent slot
q35: compat: keep hotplugged PCIe device broken after migration for
6.2 and older machine types

 include/hw/acpi/pcihp.h                    |  1 +
 include/hw/pci-bridge/xio3130_downstream.h | 15 +++++++++++++++
 include/hw/pci/pcie.h                      |  1 +
 hw/acpi/ich9.c                             | 20 ++++++++++++++++++++
 hw/acpi/pcihp.c                            | 15 ++++++++++++++-
 hw/core/machine.c                          |  4 +++-
 hw/pci-bridge/xio3130_downstream.c         |  3 ++-
 hw/pci/pcie.c                              | 11 +++++++++++
 8 files changed, 67 insertions(+), 3 deletions(-)
 create mode 100644 include/hw/pci-bridge/xio3130_downstream.h
Signature · 1 line
2.31.1