Skip to content

input: misc: Add IBM Operation Panel driver

Eddie James linux-devicetree linux-input lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v42 patches 1 replySuperseded

Changes in v5 from the cover letter

- Fix missing input include in dt binding resulting in make check failure

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: input: Add documentation for IBM Operation PanelDocumentation/devicetree/bindings/input/ibm,op-panel.yaml MAINTAINERS+56 -00 replies
2/2input: misc: Add IBM Operation Panel driverMAINTAINERS drivers/input/misc/Kconfig drivers/input/misc/Makefile +1 more+218 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringJoel StanleyWolfram Sang
1/2R-b A-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/2] input: misc: Add IBM Operation Panel driver

This series adds support for input from the IBM Operation Panel, which is a simple controller with three buttons and an LCD display meant for interacting with a server. It's connected over I2C, typically to a service processor. This series only supports the input from the panel, in which the panel masters the I2C bus and sends data to the host system when someone presses a button on the controller.

Changes since v4:
- Fix missing input include in dt binding resulting in make check failure

Changes since v3:
- Document linux,keycodes property
- Use linux,keycodes property to map the buttons
- Put the checksumming in a seperate function
- Don't do unneccessary input_unregister calls
- Minor cleanup and add debug data to dev_dbg calls

Changes since v2:
- Add "additionalProperties: false" to dts doc
- Refactor switch statement in the input driver; check command size and call the processing function within the STOP case
- Use a different definition name for Aspeed interrupt status mask

Changes since v1:
- Redo DTS documentation example to use I2C_OWN_SLAVE_ADDRESS
- Reject commands received in the input driver that are too long
- Add a definition for the interrupt status mask in the Aspeed I2C driver
- Use I2C_OWN_SLAVE_ADDRESS for both dts additions

Eddie James (2):
dt-bindings: input: Add documentation for IBM Operation Panel
input: misc: Add IBM Operation Panel driver

 .../bindings/input/ibm,op-panel.yaml          |  50 +++++
 MAINTAINERS                                   |   7 +
 drivers/input/misc/Kconfig                    |  18 ++
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/ibm-panel.c                | 198 ++++++++++++++++++
 5 files changed, 274 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/ibm,op-panel.yaml
 create mode 100644 drivers/input/misc/ibm-panel.c
Signature · 1 line
2.31.1