Skip to content

lpfc: Update lpfc to revision 14.2.0.0

James Smart linux-scsi 1 version Applied

Status from this message: Applied to 5.18/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/17lpfc: SLI path split: refactor lpfc_iocbqdrivers/scsi/lpfc/lpfc_bsg.c drivers/scsi/lpfc/lpfc_crtn.h drivers/scsi/lpfc/lpfc_ct.c +9 more+385 -3910 replies
2/17lpfc: SLI path split: refactor fast and slow paths to native sli4drivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_crtn.h drivers/scsi/lpfc/lpfc_hw4.h +2 more+257 -3020 replies
3/17lpfc: SLI path split: introduce lpfc_prep_wqedrivers/scsi/lpfc/lpfc_bsg.c drivers/scsi/lpfc/lpfc_crtn.h drivers/scsi/lpfc/lpfc_ct.c +2 more+200 -20 replies
4/17lpfc: SLI path split: refactor base els paths and the FLOGI pathdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_crtn.h drivers/scsi/lpfc/lpfc_ct.c +4 more+453 -2400 replies
5/17lpfc: SLI path split: refactor PLOGI/PRLI/ADISC/LOGO pathsdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_els.c drivers/scsi/lpfc/lpfc_nportdisc.c+242 -1050 replies
6/17lpfc: SLI path split: refactor the RSCN/SCR/RDF/EDC/FARPR pathsdrivers/scsi/lpfc/lpfc_els.c+81 -340 replies
7/17lpfc: SLI path split: refactor LS_ACC pathsdrivers/scsi/lpfc/lpfc_els.c+177 -670 replies
8/17lpfc: SLI path split: refactor LS_RJT pathsdrivers/scsi/lpfc/lpfc_els.c+15 -50 replies
9/17lpfc: SLI path split: refactor FDISC pathsdrivers/scsi/lpfc/lpfc_els.c+29 -180 replies
10/17lpfc: SLI path split: refactor VMID pathsdrivers/scsi/lpfc/lpfc_ct.c drivers/scsi/lpfc/lpfc_els.c+9 -70 replies
11/17lpfc: SLI path split: refactor misc ELS pathsdrivers/scsi/lpfc/lpfc_els.c drivers/scsi/lpfc/lpfc_hbadisc.c drivers/scsi/lpfc/lpfc_nportdisc.c +1 more+241 -8740 replies
12/17lpfc: SLI path split: refactor CT pathsdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_bsg.c drivers/scsi/lpfc/lpfc_crtn.h +3 more+616 -3980 replies
13/17lpfc: SLI path split: refactor SCSI pathsdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_scsi.c drivers/scsi/lpfc/lpfc_sli.c+174 -2100 replies
14/17lpfc: SLI path split: refactor Abort pathsdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_crtn.h drivers/scsi/lpfc/lpfc_nvme.c +3 more+236 -1840 replies
15/17lpfc: SLI path split: refactor BSG pathsdrivers/scsi/lpfc/lpfc_bsg.c+22 -140 replies
16/17lpfc: Update lpfc version to 14.2.0.0drivers/scsi/lpfc/lpfc_version.h+1 -10 replies
17/17lpfc: Copyright updates for 14.2.0.0 patchesdrivers/scsi/lpfc/lpfc.h drivers/scsi/lpfc/lpfc_bsg.c drivers/scsi/lpfc/lpfc_crtn.h +15 more+19 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] lpfc: Update lpfc to revision 14.2.0.0

Update lpfc to revision 14.2.0.0

This patch set is a refactoring of the lpfc driver.

The lpfc driver was first implemented for sli-3 then had sli-4 added to it. The addition of sli-4 was done in a manner where the sli-3 paths were left in place with sli-3 structures converted to sli-4 when written to the adapter. Similar behavior for responses. Over time we've been hit with subtle sli3 vs sli4 structure formats issues, bits defined on sli3 that aren't on sli4 or vice versa, that the driver wasn't careful about. The subtleties caused bogus settings to be passed when the eventually overlapped, or expected values that never we set by the hw.

Given that all sli-3 hardware is now end of life (last sli3 adapter is ~10 yrs old) we'd like to move the implementation of the driver such that it uses sli-4 as its native path and kills the "translation" layer. Sli-3 is still supported, but we're trying to move away from the sli-3 data structures that dominated the implementation and instead move to a more generic structure, and hopefully do so without huge amounts of code change for what in some respects would be naming deltas.

This patch refactors the driver to make the fast and slow paths now work on native sli-4 datastructures. Common areas or items change their names to make it clear they aren't sli-3 centric. Generic access functions to get/set common fields were created abstract the structure deltas. The different code paths were then reworked to use the generic names/routines and where rev-specific data was to be set, add explicit sections to set the items based on the revision. In this way, no translation occurs and any rev-spec delta is very clear. In performing this, some of the checking or case logic varied a little, and some code cleanups were performed.

The patches were cut against Martin's 5.17/scsi-fixes tree

James Smart (17):
lpfc: SLI path split: refactor lpfc_iocbq
lpfc: SLI path split: refactor fast and slow paths to native sli4
lpfc: SLI path split: introduce lpfc_prep_wqe
lpfc: SLI path split: refactor base els paths and the FLOGI path
lpfc: SLI path split: refactor PLOGI/PRLI/ADISC/LOGO paths
lpfc: SLI path split: refactor the RSCN/SCR/RDF/EDC/FARPR paths
lpfc: SLI path split: refactor LS_ACC paths
lpfc: SLI path split: refactor LS_RJT paths
lpfc: SLI path split: refactor FDISC paths
lpfc: SLI path split: refactor VMID paths
lpfc: SLI path split: refactor misc ELS paths
lpfc: SLI path split: refactor CT paths
lpfc: SLI path split: refactor SCSI paths
lpfc: SLI path split: refactor Abort paths
lpfc: SLI path split: refactor BSG paths
lpfc: Update lpfc version to 14.2.0.0
lpfc: Copyright updates for 14.2.0.0 patches

 drivers/scsi/lpfc/lpfc.h           |   98 +-
 drivers/scsi/lpfc/lpfc_bsg.c       |  349 ++--
 drivers/scsi/lpfc/lpfc_crtn.h      |   22 +-
 drivers/scsi/lpfc/lpfc_ct.c        |  346 ++--
 drivers/scsi/lpfc/lpfc_els.c       | 1513 +++++++++------
 drivers/scsi/lpfc/lpfc_hbadisc.c   |   46 +-
 drivers/scsi/lpfc/lpfc_hw.h        |   16 +-
 drivers/scsi/lpfc/lpfc_hw4.h       |   38 +-
 drivers/scsi/lpfc/lpfc_init.c      |   13 +-
 drivers/scsi/lpfc/lpfc_nportdisc.c |  104 +-
 drivers/scsi/lpfc/lpfc_nvme.c      |   41 +-
 drivers/scsi/lpfc/lpfc_nvme.h      |    8 +-
 drivers/scsi/lpfc/lpfc_nvmet.c     |   85 +-
 drivers/scsi/lpfc/lpfc_scsi.c      |  457 ++---
 drivers/scsi/lpfc/lpfc_sli.c       | 2831 +++++++++++++---------------
 drivers/scsi/lpfc/lpfc_sli.h       |   31 +-
 drivers/scsi/lpfc/lpfc_sli4.h      |    2 +-
 drivers/scsi/lpfc/lpfc_version.h   |    6 +-
 18 files changed, 3146 insertions(+), 2860 deletions(-)
Signature · 1 line
2.26.2