Skip to content

Extend cgroup interface with bpf

Hao Luo bpf lkml llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 41 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9bpf: Add mkdir, rmdir, unlink syscalls for prog_bpf_syscallinclude/linux/bpf.h include/uapi/linux/bpf.h kernel/bpf/inode.c +2 more+236 -319 replies
2/9bpf: Add BPF_OBJ_PIN and BPF_OBJ_GET in the bpf_sys_bpf helperinclude/linux/bpf.h kernel/bpf/inode.c kernel/bpf/syscall.c+34 -150 replies
3/9selftests/bpf: tests mkdir, rmdir, unlink and pin in syscalltools/testing/selftests/bpf/prog_tests/syscall.c tools/testing/selftests/bpf/progs/syscall_fs.c+135 -10 replies
4/9bpf: Introduce sleepable tracepointsinclude/linux/bpf.h include/linux/tracepoint-defs.h include/trace/bpf_probe.h +2 more+61 -1811 replies
5/9cgroup: Sleepable cgroup tracepoints.include/trace/events/cgroup.h kernel/cgroup/cgroup.c+50 -00 replies
6/9libbpf: Add sleepable tp_btftools/lib/bpf/libbpf.c+1 -00 replies
7/9bpf: Lift permission check in __sys_bpf when called from kernel.kernel/bpf/syscall.c+1 -12 replies
8/9bpf: Introduce cgroup iterinclude/linux/bpf.h include/uapi/linux/bpf.h kernel/bpf/Makefile +2 more+155 -19 replies
9/9selftests/bpf: Tests using sleepable tracepoints to monitor cgroup eventstools/testing/selftests/bpf/prog_tests/test_cgroup_stats.c tools/testing/selftests/bpf/progs/bpf_iter.h tools/testing/selftests/bpf/progs/cgroup_monitor.c +1 more+504 -00 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchAl Viro
1/9NAKed-by
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next v1 0/9] Extend cgroup interface with bpf

This patchset provides a bpf solution for monitoring cgroup activities and exporting cgroup states in an organized way in bpffs. It introduces the following features:

1. sleepable tracepoints and sleepable tracing programs.
2. a set of bpf helpers for creating and deleting files and directories in bpffs.
3. a new iter prog, parameterizable by cgroup ids, to print cgroup state.

Sleepable tracepoints and tracing progs allow us to run bpf progs when a new cgroup is created or an existing cgroup is removed. The set of filesystem helpers allows sleepable tracing progs to set up directories in bpffs for each cgroup. The progs can also pin and unlink bpf objects from these bpffs directories. The new iter prog can be used to export cgroup states. Using this set of additions, we are creating an extension to the current cgroup interface to export per-cgroup stats.

See the selftest added in patch 09/09, test_cgroup_stats, as a full example on how it can be done. The test develops a custom metric measuring per-cgroup scheduling latencies and exports it via cgroup iters, which are pinned by sleepable tracing progs attaching at cgroup tracepoints.

Not only for per-cgroup stats, the same approach can be used for other states such as task_vma iter and per-bpf-prog state. As an example, we can write sleepable tracing progs to monitor task fork and exit, and let the tracing prog to set up directories, parameterize task_vma iter and pin the iters.

Hao Luo (9):
bpf: Add mkdir, rmdir, unlink syscalls for prog_bpf_syscall
bpf: Add BPF_OBJ_PIN and BPF_OBJ_GET in the bpf_sys_bpf helper selftests/bpf: tests mkdir, rmdir, unlink and pin in syscall
bpf: Introduce sleepable tracepoints
cgroup: Sleepable cgroup tracepoints.
libbpf: Add sleepable tp_btf
bpf: Lift permission check in __sys_bpf when called from kernel.
bpf: Introduce cgroup iter
selftests/bpf: Tests using sleepable tracepoints to monitor cgroup
events

 include/linux/bpf.h                           |  16 +-
 include/linux/tracepoint-defs.h               |   1 +
 include/trace/bpf_probe.h                     |  22 +-
 include/trace/events/cgroup.h                 |  45 ++++
 include/uapi/linux/bpf.h                      |  32 +++
 kernel/bpf/Makefile                           |   2 +-
 kernel/bpf/cgroup_iter.c                      | 141 +++++++++++
 kernel/bpf/inode.c                            |  33 ++-
 kernel/bpf/syscall.c                          | 237 ++++++++++++++++--
 kernel/cgroup/cgroup.c                        |   5 +
 kernel/trace/bpf_trace.c                      |   5 +
 tools/include/uapi/linux/bpf.h                |  32 +++
 tools/lib/bpf/libbpf.c                        |   1 +
 .../selftests/bpf/prog_tests/syscall.c        |  67 ++++-
 .../bpf/prog_tests/test_cgroup_stats.c        | 187 ++++++++++++++
 tools/testing/selftests/bpf/progs/bpf_iter.h  |   7 +
 .../selftests/bpf/progs/cgroup_monitor.c      |  78 ++++++
 .../selftests/bpf/progs/cgroup_sched_lat.c    | 232 +++++++++++++++++
 .../testing/selftests/bpf/progs/syscall_fs.c  |  69 +++++
 19 files changed, 1175 insertions(+), 37 deletions(-)
 create mode 100644 kernel/bpf/cgroup_iter.c
 create mode 100644 tools/testing/selftests/bpf/prog_tests/test_cgroup_stats.c
 create mode 100644 tools/testing/selftests/bpf/progs/cgroup_monitor.c
 create mode 100644 tools/testing/selftests/bpf/progs/cgroup_sched_lat.c
 create mode 100644 tools/testing/selftests/bpf/progs/syscall_fs.c
Signature · 1 line
2.35.1.574.g5d30c73bfb-goog