Skip to content

drm/i915/ttm: Evict and restore of compressed object

Ramalingam C dri-devel intel-gfx 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest9 patches 1 replyIn review
  2. v89 patches 0 repliesSuperseded
  3. v7 posting 2/29 patches 7 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v7 posting 1/29 patches8 repliesSuperseded
v59 patches8 repliesSuperseded
v48 patches6 repliesSuperseded
v36 patches3 repliesSuperseded
v24 patches6 repliesSuperseded
v61 patch0 repliesSuperseded
v11 patch1 replySuperseded

Changes in v9 from the cover letter

New patch for return value fix
Fix a return error code

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915/gt: use engine instance directly for offsetdrivers/gpu/drm/i915/gt/intel_migrate.c+4 -70 replies
2/9drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+drivers/gpu/drm/i915/gt/intel_gpu_commands.h drivers/gpu/drm/i915/gt/intel_migrate.c+43 -50 replies
3/9drm/i915/gt: Optimize the migration and clear loopdrivers/gpu/drm/i915/gt/intel_migrate.c+17 -170 replies
4/9drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTEdrivers/gpu/drm/i915/gt/intel_migrate.c+5 -11 reply
5/9drm/i915/gt: Clear compress metadata for Flat-ccs objectsdrivers/gpu/drm/i915/gt/intel_gpu_commands.h drivers/gpu/drm/i915/gt/intel_migrate.c+152 -10 replies
6/9drm/i915/selftest_migrate: Consider the possible roundup of sizedrivers/gpu/drm/i915/gt/selftest_migrate.c+3 -00 replies
7/9drm/i915/selftest_migrate: Check CCS meta data cleardrivers/gpu/drm/i915/gt/selftest_migrate.c+222 -280 replies
8/9drm/i915/gem: Add extra pages in ttm_tt for ccs datadrivers/gpu/drm/i915/gem/i915_gem_ttm.c+29 -10 replies
9/9drm/i915/migrate: Evict and restore the flatccs capable lmem objdrivers/gpu/drm/i915/gt/intel_migrate.c+160 -40 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchThomas HellstromNirmoy Das
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/9] drm/i915/ttm: Evict and restore of compressed object

On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats.

The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the required memory is reserved for the CCS data and a secure register will be programmed with the CCS base address

So when we allocate a object in local memory we dont need to explicitly allocate the space for ccs data. But when we evict the obj into the smem to hold the compression related data along with the obj we need smem space of obj_size + (obj_size/256).

Hence when we create smem for an obj with lmem placement possibility we create with the extra space.

When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content.

When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the ccs data corresponding to the lmem main memory. So main memory of lmem will be copied into the initial pages of the smem and then ccs data corresponding to the main memory will be copied to the subsequent pages of smem.

Swapin happens exactly in reverse order. First main memory of lmem is restored from the smem's initial pages and the ccs data will be restored from the subsequent pages of smem.

Extracting and restoring the CCS data is done through a special cmd called XY_CTRL_SURF_COPY_BLT

v8 and v9:
New patch for return value fix
Fix a return error code

Test-with: [email protected]

Ramalingam C (9):
drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ drm/i915/gt: Optimize the migration and clear loop drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE drm/i915/gt: Clear compress metadata for Flat-ccs objects drm/i915/selftest_migrate: Consider the possible roundup of size drm/i915/selftest_migrate: Check CCS meta data clear drm/i915/gem: Add extra pages in ttm_tt for ccs data drm/i915/migrate: Evict and restore the flatccs capable lmem obj

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c      |  30 +-
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  21 +
 drivers/gpu/drm/i915/gt/intel_migrate.c      | 387 +++++++++++++++++--
 drivers/gpu/drm/i915/gt/selftest_migrate.c   | 253 ++++++++++--
 4 files changed, 631 insertions(+), 60 deletions(-)
Signature · 1 line
2.20.1