Skip to content

usb: gadget: use after free in dev_config

Hangyu Hua linux-usb lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: gadget: don't release an existing dev->bufdrivers/usb/gadget/legacy/inode.c+2 -10 replies
2/2usb: gadget: clear related members when goto faildrivers/usb/gadget/legacy/inode.c+5 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAlan Stern
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 4.14 0/2] usb: gadget: use after free in dev_config

Author: Hangyu Hua <[email protected]>
commit 89f3594d0de5 ("usb: gadget: don't release an existing dev->buf")

Author: Hangyu Hua <[email protected]>
commit 501e38a5531e ("usb: gadget: clear related members when goto fail")

Add two commits to all stable branches.

There are two bugs:
dev->buf does not need to be released if it already exists before executing dev_config.
dev->config and dev->hs_config and dev->dev need to be cleaned if dev_config fails to avoid UAF.

Hangyu Hua (2):
usb: gadget: don't release an existing dev->buf
usb: gadget: clear related members when goto fail

 drivers/usb/gadget/legacy/inode.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1