Many improvements to HVF memory-related codes
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest9 patches 7 repliesIn review
Changes in v3 from the cover letter
* Fix last two patches which contain mistakes:
- hvf: only consider directly writeable memory regions for dirty-tracking
- hvf: remove the need to lookup memory slots when clearing dirty-bits
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | hvf: move memory related functions from hvf-accel-ops.c to hvf-mem.caccel/ accel/ accel/ +1 more | +256 | 1 reply | |
| 2/9 | hvf: simplify data structures and codes of memory related functionsaccel/ accel/ include/ | +107 | 1 reply | |
| 3/9 | hvf: use correct data types for addresses in memory related functionsaccel/ include/ | +5 | 1 reply | |
| 4/9 | hvf: rename struct hvf_slot to HVFSlotaccel/ include/ target/ | +13 | 1 reply | |
| 5/9 | hvf: fix memory dirty-trackingaccel/ include/ target/ +1 more | +68 | 1 reply | |
| 6/9 | hvf: add a lock for memory related functionsaccel/ | +18 | 1 reply | |
| 7/9 | hvf: use GTree to store memory slots instead of fixed-size arrayaccel/ | +32 | 1 reply | |
| 8/9 | hvf: only consider directly writeable memory regions for dirty-trackingaccel/ | +6 | 0 replies | |
| 9/9 | hvf: remove the need to lookup memory slots when clearing dirty-bitsaccel/ | +21 | 0 replies |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell |
|---|---|
| 1/9 | R-b |
| 2/9 | |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] Many improvements to HVF memory-related codes
changes in v3:
* Fix last two patches which contain mistakes:
- hvf: only consider directly writeable memory regions for dirty-tracking
- hvf: remove the need to lookup memory slots when clearing dirty-bits
changes in v2:
* Rebase to the current master.
* Correct a mistake in "hvf: simplify data structures and codes of memory related functions" patch
* add two patches for HVF memory listener. The changes are
- only consider directly writeable memory regions for dirty-tracking
- in hvf_log_clear, use provided section (MemoryRegionSection) from the caller to determine the pages that need to write-protected instead of calling hvf_set_dirty_tracking to write-protect the memory slots that contains the pages whose dirty-bits are cleared.
----------
I recently bought a Mac with M1 Pro chip, and use QEMU to setup a Linux virtual machine. QEMU crashed when I started a VM with HVF accelerator enabled and with the device, bochs-display, added.
After digging into the source code, I found that dirty-tracking in HVF did not work properly, which made QEMU crashed. Therefore I made this series of patches to fix the problem.
Followings are the summary of the changes that these patches make:
1. Move HVF memory-related functions and codes into a new file hvf-mem.c
2. Simplify the logics of adding and removing memory regions in HVF memory listener
3. Fix HVF dirty-tracking logics for both Intel and Apple Silicon Macs
4. Use GTree and dynamically-allocated structures to store HVF memory slots instead of fixed-size arrays. This makes memory slots more scalable. It is inspired by the recent changes in Linux kernel (v5.17) that use red-black trees instead of arrays to store in-kernel KVM memory slots.
5. Add a lock to protect the data structures of HVF memory slots
Patches have been tested on Apple Silicon Macs and Intel Macs.
Yan-Jie Wang (9):
hvf: move memory related functions from hvf-accel-ops.c to hvf-mem.c
hvf: simplify data structures and codes of memory related functions
hvf: use correct data types for addresses in memory related functions
hvf: rename struct hvf_slot to HVFSlot
hvf: fix memory dirty-tracking
hvf: add a lock for memory related functions
hvf: use GTree to store memory slots instead of fixed-size array
hvf: only consider directly writeable memory regions for
dirty-tracking
hvf: remove the need to lookup memory slots when clearing dirty-bits
accel/hvf/hvf-accel-ops.c | 221 +----------------------- accel/hvf/hvf-mem.c | 343 ++++++++++++++++++++++++++++++++++++++ accel/hvf/meson.build | 1 + include/sysemu/hvf_int.h | 18 +- target/arm/hvf/hvf.c | 5 + target/i386/hvf/hvf.c | 25 +-- 6 files changed, 359 insertions(+), 254 deletions(-) create mode 100644 accel/hvf/hvf-mem.c
Signature · 1 line
2.32.0 (Apple Git-132)