tests: introduce testing coverage for TLS with migration
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 9 repliesIn review
- v218 patches 17 repliesSuperseded
- v118 patches 29 repliesSuperseded
Changes in v3 from the cover letter
- Trivial rebase dropping already merged patches
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | tests: fix encoding of IP addresses in x509 certstests/ tests/ | +22 | 1 reply | |
| 2/9 | tests: add more helper macros for creating TLS x509 certstests/ | +53 | 1 reply | |
| 3/9 | tests: add migration tests of TLS with PSK credentialstests/ tests/ tests/ +1 more | +177 | 2 replies | |
| 4/9 | tests: add migration tests of TLS with x509 credentialsmeson.build tests/ tests/ | +386 | 1 reply | |
| 5/9 | tests: convert XBZRLE migration test to use common helpertests/ | +25 | 0 replies | |
| 6/9 | tests: convert multifd migration tests to use common helpertests/ | +40 | 0 replies | |
| 7/9 | tests: add multifd migration tests of TLS with PSK credentialstests/ | +56 | 1 reply | |
| 8/9 | tests: add multifd migration tests of TLS with x509 credentialstests/ | +127 | 1 reply | |
| 9/9 | tests: ensure migration status isn't reported as failedtests/ tests/ tests/ | +17 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Peter Xu | Dr. David Alan Gilbert | Eric Blake |
|---|---|---|---|
| 1/9 | R-b | ||
| 2/9 | R-b | ||
| 3/9 | R-b | ||
| 4/9 | R-b | ||
| 5/9 | R-b | ||
| 6/9 | R-b | ||
| 7/9 | R-b | ||
| 8/9 | R-b | ||
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/9] tests: introduce testing coverage for TLS with migration
This significantly expands the migration test suite to cover testing with TLS over TCP and UNIX sockets, with both PSK (pre shared keys) and x509 credentials, and for both single and multifd scenarios.
It identified one bug in handling PSK credentials with UNIX sockets, but other than that everything was operating as expected.
To minimize the impact on code duplication alopt of refactoring is done of the migration tests to introduce a common helper for running the migration process. The various tests mostly just have to provide a callback to set a few parameters/capabilities before migration starts, and sometimes a callback to cleanup or validate after completion/failure.
Changed in v3:
- Trivial rebase dropping already merged patches
Changed in v2:
- Use structs to pass around most parameters
- Hide expected errors from stderr
Daniel P. Berrangé (9):
tests: fix encoding of IP addresses in x509 certs
tests: add more helper macros for creating TLS x509 certs
tests: add migration tests of TLS with PSK credentials
tests: add migration tests of TLS with x509 credentials
tests: convert XBZRLE migration test to use common helper
tests: convert multifd migration tests to use common helper
tests: add multifd migration tests of TLS with PSK credentials
tests: add multifd migration tests of TLS with x509 credentials
tests: ensure migration status isn't reported as failed
meson.build | 1 + tests/qtest/meson.build | 12 +- tests/qtest/migration-helpers.c | 13 + tests/qtest/migration-helpers.h | 1 + tests/qtest/migration-test.c | 866 ++++++++++++++++++++++++--- tests/unit/crypto-tls-psk-helpers.c | 18 +- tests/unit/crypto-tls-psk-helpers.h | 1 + tests/unit/crypto-tls-x509-helpers.c | 16 +- tests/unit/crypto-tls-x509-helpers.h | 53 ++ tests/unit/test-crypto-tlssession.c | 11 +- 10 files changed, 897 insertions(+), 95 deletions(-)
Signature · 1 line
2.35.1