Skip to content

s390x/tcg: Implement Vector-Enhancements Facility 2

David Miller qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest11 patches 7 repliesIn review
  2. v411 patches 17 repliesSuperseded
  3. v27 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches6 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11tcg: Implement tcg_gen_{h,w}swap_{i32,i64}include/tcg/tcg-op.h tcg/tcg-op.c+36 -00 replies
2/11target/s390x: vxeh2: vector convert short/32btarget/s390x/helper.h target/s390x/tcg/translate_vx.c.inc target/s390x/tcg/vec_fpu_helper.c+75 -40 replies
3/11target/s390x: vxeh2: vector string searchtarget/s390x/helper.h target/s390x/tcg/insn-data.def target/s390x/tcg/translate.c +2 more+134 -10 replies
4/11target/s390x: vxeh2: Update for changes to vector shiftstarget/s390x/helper.h target/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc +1 more+95 -500 replies
5/11target/s390x: vxeh2: vector shift double by bittarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+53 -80 replies
6/11target/s390x: vxeh2: vector {load, store} elements reversedtarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+88 -00 replies
7/11target/s390x: vxeh2: vector {load, store} byte reversed elementstarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+117 -01 reply
8/11target/s390x: vxeh2: vector {load, store} byte reversed elementtarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+97 -00 replies
9/11target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU modeltarget/s390x/gen-features.c+2 -02 replies
10/11tests/tcg/s390x: Tests for Vector Enhancements Facility 2tests/tcg/s390x/Makefile.target tests/tcg/s390x/vx.h tests/tcg/s390x/vxeh2_vcvt.c +2 more+347 -00 replies
11/11target/s390x: Fix writeback to v1 in helper_vstltarget/s390x/tcg/vec_helper.c+0 -20 replies

Reviews trailers per patch

8 of 11 patches have a Reviewed-by or Acked-by.

PatchDavid HildenbrandDavid MillerThomas Huth
SeriesT-b
1/11R-b R-b
2/11R-b
3/11R-b
4/11R-b
5/11
6/11R-b
7/11R-b
8/11R-b
9/11
10/11
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

Implement Vector-Enhancements Facility 2 for s390x

resolves: https://gitlab.com/qemu-project/qemu/-/issues/738

implements:

    VECTOR LOAD ELEMENTS REVERSED               (VLER)
    VECTOR LOAD BYTE REVERSED ELEMENTS          (VLBR)
    VECTOR LOAD BYTE REVERSED ELEMENT           (VLEBRH, VLEBRF, VLEBRG)
    VECTOR LOAD BYTE REVERSED ELEMENT AND ZERO  (VLLEBRZ)

VECTOR LOAD BYTE REVERSED ELEMENT AND REPLICATE (VLBRREP)
VECTOR STORE ELEMENTS REVERSED (VSTER)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTBR)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTEBRH, VSTEBRF, VSTEBRG)
VECTOR SHIFT LEFT DOUBLE BY BIT (VSLD)
VECTOR SHIFT RIGHT DOUBLE BY BIT (VSRD)
VECTOR STRING SEARCH (VSTRS)

modifies:
VECTOR FP CONVERT FROM FIXED (VCFPS)
VECTOR FP CONVERT FROM LOGICAL (VCFPL)
VECTOR FP CONVERT TO FIXED (VCSFP)
VECTOR FP CONVERT TO LOGICAL (VCLFP)
VECTOR SHIFT LEFT (VSL)
VECTOR SHIFT RIGHT ARITHMETIC (VSRA)
VECTOR SHIFT RIGHT LOGICAL (VSRL)

David Miller (9):
tcg: Implement tcg_gen_{h,w}swap_{i32,i64} target/s390x: vxeh2: vector convert short/32b target/s390x: vxeh2: vector string search target/s390x: vxeh2: Update for changes to vector shifts target/s390x: vxeh2: vector shift double by bit target/s390x: vxeh2: vector {load, store} elements reversed target/s390x: vxeh2: vector {load, store} byte reversed elements target/s390x: vxeh2: vector {load, store} byte reversed element target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model tests/tcg/s390x: Tests for Vector Enhancements Facility 2 target/s390x: Fix writeback to v1 in helper_vstl

Richard Henderson (2):
tcg: Implement tcg_gen_{h,w}swap_{i32,i64} target/s390x: Fix writeback to v1 in helper_vstl

 include/tcg/tcg-op.h                 |   6 +
 target/s390x/gen-features.c          |   2 +
 target/s390x/helper.h                |  13 +
 target/s390x/tcg/insn-data.def       |  40 ++-
 target/s390x/tcg/translate.c         |   3 +-
 target/s390x/tcg/translate_vx.c.inc  | 461 ++++++++++++++++++++++++---
 target/s390x/tcg/vec_fpu_helper.c    |  31 ++
 target/s390x/tcg/vec_helper.c        |   2 -
 target/s390x/tcg/vec_int_helper.c    |  55 ++++
 target/s390x/tcg/vec_string_helper.c |  99 ++++++
 tcg/tcg-op.c                         |  30 ++
 tests/tcg/s390x/Makefile.target      |   8 +
 tests/tcg/s390x/vx.h                 |  19 ++
 tests/tcg/s390x/vxeh2_vcvt.c         |  88 +++++
 tests/tcg/s390x/vxeh2_vlstr.c        | 139 ++++++++
 tests/tcg/s390x/vxeh2_vs.c           |  93 ++++++
 16 files changed, 1034 insertions(+), 55 deletions(-)
 create mode 100644 tests/tcg/s390x/vx.h
 create mode 100644 tests/tcg/s390x/vxeh2_vcvt.c
 create mode 100644 tests/tcg/s390x/vxeh2_vlstr.c
 create mode 100644 tests/tcg/s390x/vxeh2_vs.c
Signature · 1 line
2.34.1