Skip to content

mac80211: Trigger disconnect for STA during target hardware restart

Youghandhar Chintala ath10k linux-wireless lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 2 repliesIn review
  2. v52 patches 1 replySuperseded
  3. v42 patches 2 repliesSuperseded

Changes in v6 from the cover letter

- Fixed kernel test robot error

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mac80211: Add support to trigger sta disconnect on hardware restartinclude/net/mac80211.h net/mac80211/ieee80211_i.h net/mac80211/mlme.c +1 more+56 -41 reply
2/2ath10k: Trigger sta disconnect on hardware restartdrivers/net/wireless/ath/ath10k/core.c drivers/net/wireless/ath/ath10k/hw.h+27 -01 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchBrian Norris
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] mac80211: Trigger disconnect for STA during target hardware restart

Currently in case of target hardware restart ,we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted.

Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and the mac sequence number will restart from zero after target hardware restart leading to mismatch in the sequence number expected by the remote peer vs the sequence number of the frame sent by the target firmware.

This mismatch in sequence number will cause out-of-order packets on the remote peer and all the frames sent by the device are dropped until we reach the sequence number which was sent before we restarted the target hardware

In order to fix this, we trigger a disconnect in case of hardware restart. After this there will be a fresh connection and thereby avoiding the dropping of frames by remote peer.

The right fix would be to pull the entire data path into the host which is not feasible or would need lots of complex/inefficient datapath changes.

---
Changes from v5:
- Fixed kernel test robot error

Youghandhar Chintala (2):
mac80211: Add support to trigger sta disconnect on hardware restart
ath10k: Trigger sta disconnect on hardware restart

 drivers/net/wireless/ath/ath10k/core.c | 25 +++++++++++++++++++
 drivers/net/wireless/ath/ath10k/hw.h   |  2 ++
 include/net/mac80211.h                 | 10 ++++++++
 net/mac80211/ieee80211_i.h             |  3 +++
 net/mac80211/mlme.c                    | 14 ++++++++++-
 net/mac80211/util.c                    | 33 +++++++++++++++++++++++---
 6 files changed, 83 insertions(+), 4 deletions(-)
Signature · 1 line
2.29.0