Skip to content

nbd: enable use of TLS on non-TCP transports and other TLS improvements

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 4 repliesIn review
  2. v112 patches 14 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12crypto: mandate a hostname when checking x509 creds on a clientcrypto/tlssession.c+6 -00 replies
2/12block: pass desired TLS hostname through from block driver clientblock/nbd.c include/block/nbd.h nbd/client-connection.c+15 -70 replies
3/12block/nbd: support override of hostname for TLS certificate validationblock/nbd.c qapi/block-core.json+18 -30 replies
4/12qemu-nbd: add --tls-hostname option for TLS certificate validationdocs/tools/qemu-nbd.rst qemu-nbd.c+29 -10 replies
5/12block/nbd: don't restrict TLS usage to IP socketsblock/nbd.c blockdev-nbd.c qemu-nbd.c+5 -170 replies
6/12tests/qemu-iotests: add QEMU_IOTESTS_REGEN=1 to update reference filetests/qemu-iotests/testrunner.py+6 -00 replies
7/12tests/qemu-iotests: expand _filter_nbd rulestests/qemu-iotests/common.filter+4 -00 replies
8/12tests/qemu-iotests: introduce filter for qemu-nbd export listtests/qemu-iotests/241 tests/qemu-iotests/241.out tests/qemu-iotests/common.filter+14 -31 reply
9/12tests/qemu-iotests: convert NBD TLS test to use standard filterstests/qemu-iotests/233 tests/qemu-iotests/233.out+16 -210 replies
10/12tests/qemu-iotests: validate NBD TLS with hostname mismatchtests/qemu-iotests/233 tests/qemu-iotests/233.out tests/qemu-iotests/common.tls+38 -30 replies
11/12tests/qemu-iotests: validate NBD TLS with UNIX socketstests/qemu-iotests/233 tests/qemu-iotests/233.out+39 -01 reply
12/12tests/qemu-iotests: validate NBD TLS with UNIX sockets and PSKtests/qemu-iotests/233 tests/qemu-iotests/233.out tests/qemu-iotests/common.tls+69 -02 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b T-b
9/12R-b
10/12R-b
11/12R-b T-b
12/12R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] nbd: enable use of TLS on non-TCP transports and other TLS improvements

This series was principally motivated by a desire to enabl use of TLS on non-TCP transports. For x509 certificates this means we need a way to set the hostname to use for validation. This also lets us override the hostname when connecting on a TCP transport that is tunnelled or port-forwarded. It also unlocks the ability to use PSK (pre-shared keys) with UNIX sockets which would always have worked, had it not been blocked by explicit checks in NBD code.

NB, the first patch in this series is common with my corresponding migration series for TLS

https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg00556.html

In v2:

- Tweak the filter for qemu-nbd export list to expose export name
- Add "since" tag to QAPI addition
- Minor docs fixes

Daniel P. Berrangé (12):
crypto: mandate a hostname when checking x509 creds on a client
block: pass desired TLS hostname through from block driver client block/nbd: support override of hostname for TLS certificate validation
qemu-nbd: add --tls-hostname option for TLS certificate validation block/nbd: don't restrict TLS usage to IP sockets tests/qemu-iotests: add QEMU_IOTESTS_REGEN=1 to update reference file tests/qemu-iotests: expand _filter_nbd rules tests/qemu-iotests: introduce filter for qemu-nbd export list tests/qemu-iotests: convert NBD TLS test to use standard filters tests/qemu-iotests: validate NBD TLS with hostname mismatch tests/qemu-iotests: validate NBD TLS with UNIX sockets tests/qemu-iotests: validate NBD TLS with UNIX sockets and PSK

 block/nbd.c                      | 25 +++++---
 blockdev-nbd.c                   |  6 --
 crypto/tlssession.c              |  6 ++
 docs/tools/qemu-nbd.rst          | 13 +++++
 include/block/nbd.h              |  3 +-
 nbd/client-connection.c          | 12 +++-
 qapi/block-core.json             |  3 +
 qemu-nbd.c                       | 25 ++++++--
 tests/qemu-iotests/233           | 99 +++++++++++++++++++++++++++-----
 tests/qemu-iotests/233.out       | 56 +++++++++++++++---
 tests/qemu-iotests/241           |  6 +-
 tests/qemu-iotests/241.out       |  6 ++
 tests/qemu-iotests/common.filter |  9 +++
 tests/qemu-iotests/common.tls    | 31 +++++++++-
 tests/qemu-iotests/testrunner.py |  6 ++
 15 files changed, 255 insertions(+), 51 deletions(-)
Signature · 1 line
2.34.1