Skip to content

net: dev: add skb drop reasons to net/core/dev.c

[email protected] bpf lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesApplied 7/7
  2. v17 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- rename SKB_DROP_REASON_QDISC_EGRESS to SKB_DROP_REASON_TC_EGRESS in the 1th patch
- remove the 'else' in the 4th patch
- rename SKB_DROP_REASON_QDISC_INGRESS to SKB_DROP_REASON_TC_INGRESS in the 6th patch

Patches in v2 All 7 applied

#Subject and filesSizeRepliesApplied
1/7net: dev: use kfree_skb_reason() for sch_handle_egress()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+3 -10 repliesApplied
2/7net: skb: introduce the function kfree_skb_list_reason()include/linux/skbuff.h net/core/skbuff.c+11 -40 repliesApplied
3/7net: dev: add skb drop reasons to __dev_xmit_skb()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+8 -20 repliesApplied
4/7net: dev: use kfree_skb_reason() for enqueue_to_backlog()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+11 -10 repliesApplied
5/7net: dev: use kfree_skb_reason() for do_xdp_generic()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+3 -10 repliesApplied
6/7net: dev: use kfree_skb_reason() for sch_handle_ingress()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+3 -10 repliesApplied
7/7net: dev: use kfree_skb_reason() for __netif_receive_skb_core()include/linux/skbuff.h include/trace/events/skb.h net/core/dev.c+11 -30 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/7] net: dev: add skb drop reasons to net/core/dev.c

From: Menglong Dong <[email protected]>

In the commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()"), we added the support of reporting the reasons of skb drops to kfree_skb tracepoint. And in this series patches, reasons for skb drops are added to the link layer, which means that 'net/core/dev.c' is our target.

Following functions are processed:

sch_handle_egress()
__dev_xmit_skb()
enqueue_to_backlog()
do_xdp_generic()
sch_handle_ingress()
__netif_receive_skb_core()

and following new drop reasons are added (what they mean can be see in the document of them):

SKB_DROP_REASON_TC_EGRESS
SKB_DROP_REASON_QDISC_DROP
SKB_DROP_REASON_CPU_BACKLOG
SKB_DROP_REASON_XDP
SKB_DROP_REASON_TC_INGRESS
SKB_DROP_REASON_PTYPE_ABSENT

In order to add skb drop reasons to kfree_skb_list(), the function kfree_skb_list_reason() is introduced in the 2th patch, which will be used in __dev_xmit_skb() in the 3th patch.

Changes since v1:
- rename SKB_DROP_REASON_QDISC_EGRESS to SKB_DROP_REASON_TC_EGRESS in the 1th patch
- remove the 'else' in the 4th patch
- rename SKB_DROP_REASON_QDISC_INGRESS to SKB_DROP_REASON_TC_INGRESS in the 6th patch

Menglong Dong (7):
net: dev: use kfree_skb_reason() for sch_handle_egress()
net: skb: introduce the function kfree_skb_list_reason()
net: dev: add skb drop reasons to __dev_xmit_skb()
net: dev: use kfree_skb_reason() for enqueue_to_backlog()
net: dev: use kfree_skb_reason() for do_xdp_generic()
net: dev: use kfree_skb_reason() for sch_handle_ingress()
net: dev: use kfree_skb_reason() for __netif_receive_skb_core()

 include/linux/skbuff.h     | 26 +++++++++++++++++++++++++-
 include/trace/events/skb.h |  6 ++++++
 net/core/dev.c             | 24 +++++++++++++++---------
 net/core/skbuff.c          |  7 ++++---
 4 files changed, 50 insertions(+), 13 deletions(-)
Signature · 1 line
2.35.1