Skip to content

drm: Support GEM SHMEM fbdev without shadow FB

Thomas Zimmermann dri-devel linux-fbdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/simpledrm: Use fbdev defaults for shadow bufferingdrivers/gpu/drm/tiny/simpledrm.c+0 -13 replies
2/9fbdev: Put mmap for deferred I/O into driversdrivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/vmwgfx/vmwgfx_fb.c drivers/hid/hid-picolcd_fb.c +12 more+34 -111 reply
3/9fbdev: Track deferred-I/O pages in pageref structdrivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/vmwgfx/vmwgfx_fb.c drivers/staging/fbtft/fbtft-core.c +9 more+147 -693 replies
4/9fbdev: Export helper for implementing page_mkwritedrivers/video/fbdev/core/fb_defio.c include/linux/fb.h+50 -201 reply
5/9drm/fb-helper: Separate deferred I/O from shadow buffersdrivers/gpu/drm/drm_fb_helper.c+30 -51 reply
6/9drm/fb-helper: Provide callback to create fbdev dumb buffersdrivers/gpu/drm/drm_client.c drivers/gpu/drm/drm_crtc_internal.h drivers/gpu/drm/drm_dumb_buffers.c +3 more+84 -153 replies
7/9drm/fb-helper: Provide fbdev deferred-I/O helpersdrivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+19 -01 reply
8/9drm/gem-shmem: Implement fbdev dumb buffer and mmap helpersdrivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/gud/gud_drv.c drivers/gpu/drm/hyperv/hyperv_drm_drv.c +7 more+240 -363 replies
9/9drm/virtio: Implement dumb_create_fbdev with GEM SHMEM helpersdrivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/virtio/virtgpu_drv.c drivers/gpu/drm/virtio/virtgpu_drv.h +2 more+71 -43 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez Canillas
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] drm: Support GEM SHMEM fbdev without shadow FB

Rework the fbdev deferred-I/O to not interfere with fields of struct page. Make the code more flexible and implement GEM SHMEM mmap on top of it.

This patchset removes the need for a special shadow framebuffer for fbdev mmap when using GEM SHMEM. SHMEM pages are now mmap'ed from /dev/fb directly.

Patches 2 and 3 rework the fbdev deferred I/O code. It now allows drivers to have better control of the mmap operations. All references to fields in struct page are gone. The rsp state is help in a separate pageref structure.

Patches 4 to 7 provide callbacks an helpers to implement deferred I/O with DRM drivers. Specifically, patch 6 introduces a callback to create a dumb buffer for fbdev. This will be useful for many drivers that currently cannot use generic fbdev emulation because of special placement needs of the BO, such as amdgpu or radeon. The drivers can handle the differences to regular dumb buffers in their new callback implementation.

Patch 8 extends the GEM SHMEM memory manager with a new helper for fbdev dumb-buffer creation. The returned BO has it's mmap set up to implement deferred I/O with SHMEM pages. No additional shadow buffer is requires any longer. Many drivers can immediatelly benefit from this change.

Patch 9 extends virtgpu to support fbdev dumb buffers. It's build on top of GEM SHMEM, but has some modifications that need to be implemented for fbdev as well.

There's no immediate fbdev performance improvement from this patchset. Most of all, it removes unnecessary shadow framebuffers and rsp memcpys. A shadow fb for a FullHD display is ~8 MiB, which we now save. The patches do reduce latency between drawing to the fbdev buffer to displaying on the screen. Watching a video on the fbdev console felt smoother and had less flickering.

Thomas Zimmermann (9):
drm/simpledrm: Use fbdev defaults for shadow buffering
fbdev: Put mmap for deferred I/O into drivers
fbdev: Track deferred-I/O pages in pageref struct
fbdev: Export helper for implementing page_mkwrite drm/fb-helper: Separate deferred I/O from shadow buffers drm/fb-helper: Provide callback to create fbdev dumb buffers drm/fb-helper: Provide fbdev deferred-I/O helpers drm/gem-shmem: Implement fbdev dumb buffer and mmap helpers drm/virtio: Implement dumb_create_fbdev with GEM SHMEM helpers

 drivers/gpu/drm/drm_client.c            |  14 +-
 drivers/gpu/drm/drm_crtc_internal.h     |   3 +
 drivers/gpu/drm/drm_dumb_buffers.c      |  36 +++-
 drivers/gpu/drm/drm_fb_helper.c         |  79 +++++++--
 drivers/gpu/drm/drm_gem_shmem_helper.c  | 204 ++++++++++++++++++++---
 drivers/gpu/drm/gud/gud_drv.c           |   2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c |   2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c   |   2 +-
 drivers/gpu/drm/tiny/cirrus.c           |   2 +-
 drivers/gpu/drm/tiny/gm12u320.c         |   2 +-
 drivers/gpu/drm/tiny/simpledrm.c        |   3 +-
 drivers/gpu/drm/udl/udl_drv.c           |   2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c    |   2 +
 drivers/gpu/drm/virtio/virtgpu_drv.h    |   2 +
 drivers/gpu/drm/virtio/virtgpu_object.c |  54 +++++-
 drivers/gpu/drm/vkms/vkms_drv.c         |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c      |   6 +-
 drivers/hid/hid-picolcd_fb.c            |   1 +
 drivers/staging/fbtft/fbtft-core.c      |   6 +-
 drivers/video/fbdev/broadsheetfb.c      |   6 +-
 drivers/video/fbdev/core/fb_defio.c     | 211 +++++++++++++++++-------
 drivers/video/fbdev/core/fbmem.c        |  19 +--
 drivers/video/fbdev/hecubafb.c          |   1 +
 drivers/video/fbdev/hyperv_fb.c         |   6 +-
 drivers/video/fbdev/metronomefb.c       |   6 +-
 drivers/video/fbdev/sh_mobile_lcdcfb.c  |  12 +-
 drivers/video/fbdev/smscufx.c           |   8 +-
 drivers/video/fbdev/ssd1307fb.c         |   1 +
 drivers/video/fbdev/udlfb.c             |   8 +-
 drivers/video/fbdev/xen-fbfront.c       |   6 +-
 include/drm/drm_client.h                |   3 +-
 include/drm/drm_drv.h                   |  27 +++
 include/drm/drm_fb_helper.h             |   9 +
 include/drm/drm_gem_shmem_helper.h      |  63 ++++++-
 include/linux/fb.h                      |  12 +-
 35 files changed, 668 insertions(+), 154 deletions(-)

base-commit: 710a019ad85e96e66f7d75ee7f4733cdd8a2b0d0
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 6e1032c6302461624f33194c8b8f37103a3fa6ef

Signature · 1 line
2.35.1